You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/04/26 05:13:40 UTC
Review Request: FLUME-1151:Exclude docs directory from svn, git and rat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4887/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Ignoring the docs directory in svn, git and rat.
This addresses bug FLUME-1151.
https://issues.apache.org/jira/browse/FLUME-1151
Diffs
-----
trunk/.gitignore 1330636
trunk/pom.xml 1330636
Diff: https://reviews.apache.org/r/4887/diff
Testing
-------
Thanks,
Hari
Re: Review Request: FLUME-1151:Exclude docs directory from rat
Posted by Arvind Prabhakar <ar...@apache.org>.
> On 2012-04-27 16:31:27, Arvind Prabhakar wrote:
> > +1
Please attach the patch to the Jira.
- Arvind
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4887/#review7305
-----------------------------------------------------------
On 2012-04-26 06:09:19, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4887/
> -----------------------------------------------------------
>
> (Updated 2012-04-26 06:09:19)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Ignoring the docs directory in rat, to make binary tarball buildable.
>
>
> This addresses bug FLUME-1151.
> https://issues.apache.org/jira/browse/FLUME-1151
>
>
> Diffs
> -----
>
> trunk/pom.xml 1330636
>
> Diff: https://reviews.apache.org/r/4887/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari
>
>
Re: Review Request: FLUME-1151:Exclude docs directory from rat
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4887/#review7305
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-04-26 06:09:19, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4887/
> -----------------------------------------------------------
>
> (Updated 2012-04-26 06:09:19)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Ignoring the docs directory in rat, to make binary tarball buildable.
>
>
> This addresses bug FLUME-1151.
> https://issues.apache.org/jira/browse/FLUME-1151
>
>
> Diffs
> -----
>
> trunk/pom.xml 1330636
>
> Diff: https://reviews.apache.org/r/4887/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari
>
>
Re: Review Request: FLUME-1151:Exclude docs directory from rat
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4887/
-----------------------------------------------------------
(Updated 2012-04-26 06:09:19.078069)
Review request for Flume.
Summary (updated)
-------
Ignoring the docs directory in rat, to make binary tarball buildable.
This addresses bug FLUME-1151.
https://issues.apache.org/jira/browse/FLUME-1151
Diffs
-----
trunk/pom.xml 1330636
Diff: https://reviews.apache.org/r/4887/diff
Testing
-------
Thanks,
Hari
Re: Review Request: FLUME-1151:Exclude docs directory from svn, git and rat
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4887/
-----------------------------------------------------------
(Updated 2012-04-26 03:42:19.971584)
Review request for Flume.
Summary (updated)
-------
Ignoring the docs directory in rat, to make binary tarball buildable.
This addresses bug FLUME-1151.
https://issues.apache.org/jira/browse/FLUME-1151
Diffs
-----
trunk/pom.xml 1330636
Diff: https://reviews.apache.org/r/4887/diff
Testing
-------
Thanks,
Hari
Re: Review Request: FLUME-1151:Exclude docs directory from svn, git and rat
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4887/
-----------------------------------------------------------
(Updated 2012-04-26 03:41:48.931536)
Review request for Flume.
Changes
-------
Only excluding rat, to make binary tarball buildable. No point in changing git or svn ignores(since we don't ship these properties).
Summary
-------
Ignoring the docs directory in svn, git and rat. Seems like svn properties changes cannot be displayed by review board. Reviewboard also seems to remove it I guess. Did this:
svn propedit svn:ignore .
Added docs to the end of this.
This addresses bug FLUME-1151.
https://issues.apache.org/jira/browse/FLUME-1151
Diffs (updated)
-----
trunk/pom.xml 1330636
Diff: https://reviews.apache.org/r/4887/diff
Testing
-------
Thanks,
Hari
Re: Review Request: FLUME-1151:Exclude docs directory from svn, git and rat
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4887/
-----------------------------------------------------------
(Updated 2012-04-26 03:23:32.332292)
Review request for Flume.
Summary (updated)
-------
Ignoring the docs directory in svn, git and rat. Seems like svn properties changes cannot be displayed by review board. Reviewboard also seems to remove it I guess. Did this:
svn propedit svn:ignore .
Added docs to the end of this.
This addresses bug FLUME-1151.
https://issues.apache.org/jira/browse/FLUME-1151
Diffs
-----
trunk/.gitignore 1330636
trunk/pom.xml 1330636
Diff: https://reviews.apache.org/r/4887/diff
Testing
-------
Thanks,
Hari
Re: Review Request: FLUME-1151:Exclude docs directory from svn, git and rat
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4887/
-----------------------------------------------------------
(Updated 2012-04-26 03:19:27.938051)
Review request for Flume.
Changes
-------
Svn properties added to patch.
Summary
-------
Ignoring the docs directory in svn, git and rat. Seems like svn properties changes cannot be displayed by review board. Please download the patch to see the change.
This addresses bug FLUME-1151.
https://issues.apache.org/jira/browse/FLUME-1151
Diffs (updated)
-----
trunk/.gitignore 1330636
trunk/pom.xml 1330636
Diff: https://reviews.apache.org/r/4887/diff
Testing
-------
Thanks,
Hari
Re: Review Request: FLUME-1151:Exclude docs directory from svn, git and rat
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4887/
-----------------------------------------------------------
(Updated 2012-04-26 03:14:37.570065)
Review request for Flume.
Changes
-------
Updated description.
Summary (updated)
-------
Ignoring the docs directory in svn, git and rat. Seems like svn properties changes cannot be displayed by review board. Please download the patch to see the change.
This addresses bug FLUME-1151.
https://issues.apache.org/jira/browse/FLUME-1151
Diffs
-----
trunk/.gitignore 1330636
trunk/pom.xml 1330636
Diff: https://reviews.apache.org/r/4887/diff
Testing
-------
Thanks,
Hari