You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2024/08/15 15:52:42 UTC
[kudu-CR] [tool] Fix the copied table schema missing check bug
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21676
Change subject: [tool] Fix the copied table schema missing check bug
......................................................................
[tool] Fix the copied table schema missing check bug
Change-Id: I4621756c7e038994fb33261d3b979a7b3304dc49
---
M src/kudu/tools/table_scanner.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/21676/1
--
To view, visit http://gerrit.cloudera.org:8080/21676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4621756c7e038994fb33261d3b979a7b3304dc49
Gerrit-Change-Number: 21676
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
[kudu-CR] [tool] Fix the copied table schema missing check bug
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21676 )
Change subject: [tool] Fix the copied table schema missing check bug
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4621756c7e038994fb33261d3b979a7b3304dc49
Gerrit-Change-Number: 21676
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 15 Aug 2024 16:28:20 +0000
Gerrit-HasComments: No
[kudu-CR] [tool] Fix the copied table schema missing check bug
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21676 )
Change subject: [tool] Fix the copied table schema missing check bug
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/419/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4621756c7e038994fb33261d3b979a7b3304dc49
Gerrit-Change-Number: 21676
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 15 Aug 2024 16:46:54 +0000
Gerrit-HasComments: No
[kudu-CR] [tool] Fix the copied table schema missing check bug
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [tool] Fix the copied table schema missing check bug
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4621756c7e038994fb33261d3b979a7b3304dc49
Gerrit-Change-Number: 21676
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [tool] Fix the copied table schema missing check bug
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21676 )
Change subject: [tool] Fix the copied table schema missing check bug
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/419/
--
To view, visit http://gerrit.cloudera.org:8080/21676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4621756c7e038994fb33261d3b979a7b3304dc49
Gerrit-Change-Number: 21676
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 15 Aug 2024 15:52:49 +0000
Gerrit-HasComments: No
[kudu-CR] [tool] Fix the copied table schema missing check bug
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21676 )
Change subject: [tool] Fix the copied table schema missing check bug
......................................................................
[tool] Fix the copied table schema missing check bug
Change-Id: I4621756c7e038994fb33261d3b979a7b3304dc49
Reviewed-on: http://gerrit.cloudera.org:8080/21676
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/tools/table_scanner.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Yingchun Lai: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4621756c7e038994fb33261d3b979a7b3304dc49
Gerrit-Change-Number: 21676
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [tool] Fix the copied table schema missing check bug
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21676 )
Change subject: [tool] Fix the copied table schema missing check bug
......................................................................
Patch Set 1: Verified+1
The failed tests are unrelated.
--
To view, visit http://gerrit.cloudera.org:8080/21676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4621756c7e038994fb33261d3b979a7b3304dc49
Gerrit-Change-Number: 21676
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 16 Aug 2024 06:37:17 +0000
Gerrit-HasComments: No