You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/15 07:13:44 UTC
[GitHub] [shardingsphere] codecov-io commented on pull request #7797: refactor database dialect get delimiter

codecov-io commented on pull request #7797:
URL: https://github.com/apache/shardingsphere/pull/7797#issuecomment-708950649


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7797?src=pr&el=h1) Report
   > Merging [#7797](https://codecov.io/gh/apache/shardingsphere/pull/7797?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/07c68eaf52b847ecbc23a194442339f23bdc6022?el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `96.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7797/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7797?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7797      +/-   ##
   ============================================
   + Coverage     74.96%   75.02%   +0.05%     
   - Complexity      524      532       +8     
   ============================================
     Files          1418     1424       +6     
     Lines         22540    22552      +12     
     Branches       4051     4048       -3     
   ============================================
   + Hits          16897    16919      +22     
   + Misses         4557     4546      -11     
   - Partials       1086     1087       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7797?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...l/jdbc/handler/DatabaseMetaDataDialectHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/7797/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9qZGJjL2hhbmRsZXIvRGF0YWJhc2VNZXRhRGF0YURpYWxlY3RIYW5kbGVyLmphdmE=) | `80.00% <75.00%> (+80.00%)` | `2.00 <1.00> (+2.00)` | |
   | [...handler/impl/H2DatabaseMetaDataDialectHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/7797/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9qZGJjL2hhbmRsZXIvaW1wbC9IMkRhdGFiYXNlTWV0YURhdGFEaWFsZWN0SGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...er/impl/MariaDBDatabaseMetaDataDialectHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/7797/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9qZGJjL2hhbmRsZXIvaW1wbC9NYXJpYURCRGF0YWJhc2VNZXRhRGF0YURpYWxlY3RIYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...dler/impl/MySQLDatabaseMetaDataDialectHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/7797/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9qZGJjL2hhbmRsZXIvaW1wbC9NeVNRTERhdGFiYXNlTWV0YURhdGFEaWFsZWN0SGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ler/impl/OracleDatabaseMetaDataDialectHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/7797/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9qZGJjL2hhbmRsZXIvaW1wbC9PcmFjbGVEYXRhYmFzZU1ldGFEYXRhRGlhbGVjdEhhbmRsZXIuamF2YQ==) | `71.42% <100.00%> (+21.42%)` | `1.00 <0.00> (ø)` | |
   | [...impl/PostgreSQLDatabaseMetaDataDialectHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/7797/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9qZGJjL2hhbmRsZXIvaW1wbC9Qb3N0Z3JlU1FMRGF0YWJhc2VNZXRhRGF0YURpYWxlY3RIYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...dler/impl/SQL92DatabaseMetaDataDialectHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/7797/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9qZGJjL2hhbmRsZXIvaW1wbC9TUUw5MkRhdGFiYXNlTWV0YURhdGFEaWFsZWN0SGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../impl/SQLServerDatabaseMetaDataDialectHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/7797/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9qZGJjL2hhbmRsZXIvaW1wbC9TUUxTZXJ2ZXJEYXRhYmFzZU1ldGFEYXRhRGlhbGVjdEhhbmRsZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...cal/model/column/PhysicalColumnMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/7797/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9tb2RlbC9waHlzaWNhbC9tb2RlbC9jb2x1bW4vUGh5c2ljYWxDb2x1bW5NZXRhRGF0YUxvYWRlci5qYXZh) | `88.23% <100.00%> (+17.12%)` | `0.00 <0.00> (ø)` | |
   | [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/7797/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [17 more](https://codecov.io/gh/apache/shardingsphere/pull/7797/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7797?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7797?src=pr&el=footer). Last update [07c68ea...23cdc9f](https://codecov.io/gh/apache/shardingsphere/pull/7797?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org