[GitHub] [arrow-ballista] andygrove commented on pull request #323: Show job stages metrics

[GitBox <gi...@apache.org>]

andygrove commented on PR #323:
URL: https://github.com/apache/arrow-ballista/pull/323#issuecomment-1270116253

   Thanks @onthebridgetonowhere. This looks great. I am new to react as well and am planning on starting a course soon but have not had the chance yet.
   
   I think this is a great start (and should be merged once I have time to review/test), but ultimately I think we want to have the main view change from the job list to the query stage list when the user clicks on a query, with a link to go back to the query list somehow.
   
   I imagine that the code in App would like something like this, but again, I have no real understanding yet of react and how things like this are normally done.
   
   ```
   if (queryStage != null) {
     <Box>
       // query stage list
     </Box>
   } else {
     <Box>
       // query list
     </Box>
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org