[jira] [Commented] (ZOOKEEPER-1819) DeserializationPerfTest calls

["Daniel Knightly (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829491#comment-13829491 ] 

Daniel Knightly commented on ZOOKEEPER-1819:
--------------------------------------------

The 
SerializationPerfTest.createNodes(DataTree tree, String path, int depth,
            int childcount, int parentCVersion, byte[] data)

method is called

   SerializationPerfTest.createNodes(tree, "/", depth, tree.getNode("/").stat.getCversion(), width, new byte[len]);

but should be

   SerializationPerfTest.createNodes(tree, "/", depth, width, tree.getNode("/").stat.getCversion(), new byte[len]);

> DeserializationPerfTest calls 
> ------------------------------
>
>                 Key: ZOOKEEPER-1819
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1819
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 3.5.0
>            Reporter: Daniel Knightly
>            Priority: Minor
>             Fix For: 3.5.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The DeserializationPerfTest calls
> SerializationPerfTest.createNodes to create serialized nodes to deserialize.
> However 2 of the arguments, childcount and parentCVersion are switched in the call to the above method.  This results in all tests unintentionally testing the same scenario.



--
This message was sent by Atlassian JIRA
(v6.1#6144)