[jira] [Comment Edited] (OAK-9858) sql2 and sql2FullText tests in IndexQueryCommonTest are failing

["Nitin Gupta (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575371#comment-17575371 ] 

Nitin Gupta edited comment on OAK-9858 at 8/4/22 5:08 PM:
----------------------------------------------------------

sql2FullText -> This was a quick fix for elastic. Seems like the expectation from the test was for the indexing to be sync and thus it was working for lucene since the async property was not present on the index. I handled it in ES via a commit info to make it behave in sync fashion (support was already there - just needed to use it in the test).

 

sql2 -> This seems a bit more tricky. The problem seem to be with isChildNode() not working properly. Could be linked to https://issues.apache.org/jira/browse/OAK-9859 .

 

Now it seems during this commit here [https://github.com/apache/jackrabbit-oak/commit/3b2ef2d05af626a0a892a63842d85a742c99f84d] , when we ported the common tests, this was just failing for elastic and  we marked this as Ignore in IndexQueryCommonTest.java so this was ignored for both. 

But we kept around 
[LuceneIndexQueryTest.java|https://github.com/apache/jackrabbit-oak/commit/695d5ab33ec23ad5cae9fd47dc5f207d6dc0cd6c#diff-f6ed160388755b41eefa8f9c8ea28e2090026b15fd0b74229c7004c2ad85d82e]
So the test was being run (and passing) for lucene via this other test class. But seems like in another refactor/cleanup/test fix commit here [https://github.com/apache/jackrabbit-oak/commit/3b2ef2d05af626a0a892a63842d85a742c99f84d] , we removed the second class (probably thinking it to be redundant). So effectively we stopped testing sql2 test for lucene too.
And possibly after that something else broke it and we were not able to catch it. (Still need to figure out what broke it exactly :) )


was (Author: nitigup):
sql2FullText -> This was a quick fix for elastic. Seems like the expectation from the test was for the indexing to be sync and thus it was working for lucene since the async property was not present on the index. I handled it in ES via a commit info to make it behave in sync fashion (support was already there - just needed to use it in the test).

 

sql2 -> This seems a bit more trickt. The problem seem to be with isChildNode() not working properly. Could be linked to https://issues.apache.org/jira/browse/OAK-9859 .

 

Now it seems during this commit here [https://github.com/apache/jackrabbit-oak/commit/3b2ef2d05af626a0a892a63842d85a742c99f84d] , when we ported the common tests, this was just failing for elastic and  we marked this as Ignore in IndexQueryCommonTest.java so this was ignored for both. 

But we kept around 
[LuceneIndexQueryTest.java|https://github.com/apache/jackrabbit-oak/commit/695d5ab33ec23ad5cae9fd47dc5f207d6dc0cd6c#diff-f6ed160388755b41eefa8f9c8ea28e2090026b15fd0b74229c7004c2ad85d82e]
So the test was being run (and passing) for lucene via this other test class. But seems like in another refactor/cleanup/test fix commit here [https://github.com/apache/jackrabbit-oak/commit/3b2ef2d05af626a0a892a63842d85a742c99f84d] , we removed the second class (probably thinking it to be redundant). So effectively we stopped testing sql2 test for lucene too.
And possibly after that something else broke it and we were not able to catch it. (Still need to figure out what broke it exactly :) )

> sql2 and sql2FullText tests in IndexQueryCommonTest are failing 
> ----------------------------------------------------------------
>
>                 Key: OAK-9858
>                 URL: https://issues.apache.org/jira/browse/OAK-9858
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: indexing
>            Reporter: Nuno Santos
>            Assignee: Nitin Gupta
>            Priority: Minor
>
> {{sq2FullText}} is passing on Lucene but failing on Elastic, while {{sql2}} is failing on both. Likely related cause.
> See the test class {{{}org.apache.jackrabbit.oak.plugins.index.IndexQueryCommonTest{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)