You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/25 19:39:10 UTC

[GitHub] [solr] risdenk commented on a diff in pull request #1116: SOLR-16427: Evaluate and fix errorprone rules - part 3

risdenk commented on code in PR #1116:
URL: https://github.com/apache/solr/pull/1116#discussion_r1004894002


##########
solr/core/src/java/org/apache/solr/util/hll/SerializationUtil.java:
##########
@@ -137,8 +137,8 @@ public static byte packVersionByte(final int schemaVersion, final int typeOrdina
    *     <ul>
    *       <li>If 'explicit-disabled' is chosen, this value should be <code>0</code>.
    *       <li>If 'auto' is chosen, this value should be <code>63</code>.
-   *       <li>If a cutoff of 2<sup>n</sup> is desired, for <code>0 <= n < 31</code>, this value
-   *           should be <code>n + 1</code>.
+   *       <li>If a cutoff of 2<sup>n</sup> is desired, for <code>{@code 0 <= n < 31}</code>, this
+   *           value should be <code>{@code n + 1}</code>.

Review Comment:
   so I went back and forth on this a bunch. I need to look at the actual generated javadoc to see what it looks like. Will check it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org