You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jing Wu (JIRA)" <de...@myfaces.apache.org> on 2009/06/01 19:35:07 UTC

[jira] Created: (MFCOMMONS-9) Support java.util.Set as property type

Support java.util.Set as property type
--------------------------------------

                 Key: MFCOMMONS-9
                 URL: https://issues.apache.org/jira/browse/MFCOMMONS-9
             Project: MyFaces Commons
          Issue Type: Improvement
          Components: myfaces-commons-components
    Affects Versions: 1.0.1-SNAPSHOT
         Environment: This is generic, not specific to any OS or software/hardware specifications.
            Reporter: Jing Wu
            Priority: Minor


For some properties, java.util.Set is the best suitable type, trinidad should support java.util.Set as the property type. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (TRINIDAD-1494) Support java.util.Set as property type

Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeanne Waldman resolved TRINIDAD-1494.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.10-plugins 
                    1.2.12-core
                    1.0.11-core
         Assignee: Jeanne Waldman

> Support java.util.Set as property type
> --------------------------------------
>
>                 Key: TRINIDAD-1494
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1494
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Plugins
>         Environment: This is generic, not specific to any OS or software/hardware specifications.
>            Reporter: Jing Wu
>            Assignee: Jeanne Waldman
>            Priority: Minor
>             Fix For:  1.0.11-core,  1.2.12-core, 1.2.10-plugins 
>
>         Attachments: trinidad-1.0.patch, trinidad-1.2.11.3.patch, trinidad-mavan-plugin-trunk.patch, trinidad-maven-plugin-1.2.10.1.patch, trinidad-trunk.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> For some properties, java.util.Set is the best suitable type, trinidad should support java.util.Set as the property type. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (MFCOMMONS-9) Support java.util.Set as property type

Posted by "Jing Wu (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MFCOMMONS-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715160#action_12715160 ] 

Jing Wu commented on MFCOMMONS-9:
---------------------------------

This will have dependency on trinidad-maven-plugin. Patches for both trinidad-maven-plugin and trinidad are attached.

For the plugin, the following changes were made:

1. $plugin_root\maven-faces-plugin\src\main\java\org\apache\myfaces\trinidadbuild\plugin\faces\generator\GeneratorHelper.java 

- added a method named isKnowTypeSet(...), used by the tag generator to recognize Set<String> type.

2. $plugin_root\maven-faces-plugin\src\main\java\org\apache\myfaces\trinidadbuild\plugin\faces\generator\TrinidadComponentTagGenerator.java 

 - the generator that generates setStringSetProperty(...) method on tag files.

 

For trinidad, the following changes were made:

 1. 

$trinidad_root\trinidad-api\src\main\java\org\apache\myfaces\trinidad\webapp\UIXComponentELTag.java 

- this is the parent of all tag classes, which implements setStringSetProperty(...) that all generated tag classes depend 

 on, it converts the string to a set, and set it on the bean.

 2. 

 $trinidad_root\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\share\expl\Coercions.java 

 - add coercion case to convert String to Set.

 3. 

 $trinidad_root\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\share\xml\XMLUtils.java 

 - the actual implementation of converting String to Set, consumed by Coercions.java

 4. 

 $trinidad_root\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\taglib\util\TagUtils.java 

 - add a method getStringSet(...) that will be used by generated tag classes.

 


> Support java.util.Set as property type
> --------------------------------------
>
>                 Key: MFCOMMONS-9
>                 URL: https://issues.apache.org/jira/browse/MFCOMMONS-9
>             Project: MyFaces Commons
>          Issue Type: Improvement
>          Components: myfaces-commons-components
>    Affects Versions: 1.0.1-SNAPSHOT
>         Environment: This is generic, not specific to any OS or software/hardware specifications.
>            Reporter: Jing Wu
>            Priority: Minor
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> For some properties, java.util.Set is the best suitable type, trinidad should support java.util.Set as the property type. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.