You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/05/29 21:52:08 UTC

Review Request: SQOOP-945 Sqoop2: Integration: Auxiliary methods that will support export functionality

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11528/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've added couple of methods to support basic export functionality and one export test case.


This addresses bug SQOOP-945.
    https://issues.apache.org/jira/browse/SQOOP-945


Diffs
-----

  test/src/main/java/org/apache/sqoop/test/db/DatabaseProvider.java 72d1a95429418547efbd3566bd8143f8d759d044 
  test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java 6eb31845fd9c000ec3667581c58754934ba9d2b8 
  test/src/test/java/org/apache/sqoop/integration/connector/ConnectorTestCase.java 837a1aae6e803a10e3fbb8e88d8e3cf36455479a 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/11528/diff/


Testing
-------

New integration test seems to be passing.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-945 Sqoop2: Integration: Auxiliary methods that will support export functionality

Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11528/#review21953
-----------------------------------------------------------

Ship it!


Ship It!

- Kathleen Ting


On June 15, 2013, 8:10 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11528/
> -----------------------------------------------------------
> 
> (Updated June 15, 2013, 8:10 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added couple of methods to support basic export functionality and one export test case.
> 
> 
> This addresses bug SQOOP-945.
>     https://issues.apache.org/jira/browse/SQOOP-945
> 
> 
> Diffs
> -----
> 
>   test/src/main/java/org/apache/sqoop/test/db/DatabaseProvider.java 72d1a95429418547efbd3566bd8143f8d759d044 
>   test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java 6eb31845fd9c000ec3667581c58754934ba9d2b8 
>   test/src/test/java/org/apache/sqoop/integration/connector/ConnectorTestCase.java cdc3bd295e6dd041d6a17bc6dc8df90b8a2fc768 
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11528/diff/
> 
> 
> Testing
> -------
> 
> New integration test seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request: SQOOP-945 Sqoop2: Integration: Auxiliary methods that will support export functionality

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11528/
-----------------------------------------------------------

(Updated June 15, 2013, 8:10 p.m.)


Review request for Sqoop.


Changes
-------

Rebased on current trunk.


Description
-------

I've added couple of methods to support basic export functionality and one export test case.


This addresses bug SQOOP-945.
    https://issues.apache.org/jira/browse/SQOOP-945


Diffs (updated)
-----

  test/src/main/java/org/apache/sqoop/test/db/DatabaseProvider.java 72d1a95429418547efbd3566bd8143f8d759d044 
  test/src/test/java/org/apache/sqoop/integration/TomcatTestCase.java 6eb31845fd9c000ec3667581c58754934ba9d2b8 
  test/src/test/java/org/apache/sqoop/integration/connector/ConnectorTestCase.java cdc3bd295e6dd041d6a17bc6dc8df90b8a2fc768 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/11528/diff/


Testing
-------

New integration test seems to be passing.


Thanks,

Jarek Cecho