[GitHub] [spark] dongjoon-hyun commented on issue #25146: Fix for SPARK-28152: ShortType and FloatTypes are not mapped correctly for read/write of SQLServer Tables

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on issue #25146: Fix for SPARK-28152: ShortType and FloatTypes are not mapped correctly for read/write of SQLServer Tables
URL: https://github.com/apache/spark/pull/25146#issuecomment-511149536
 
 
   BTW, @shivsood .
   Since you are going to contribute more to Apache Spark community, I'll give you some comments on the current PR title.
   > Fix for SPARK-28152: ShortType and FloatTypes are not mapped correctly for read/write of SQLServer Tables
   
   - We use `[SPARK-28152]` prefix followed by the component tag like `[SQL]`.
   - We recommend to use the PR title to describe your approach, not a problem. The problem description and the comparison between before and after are done in the PR description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org