[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8576: [db migration] change datasources-clusters foreign key to cluster_id

[GitBox <gi...@apache.org>]

serenajiang commented on a change in pull request #8576: [db migration] change datasources-clusters foreign key to cluster_id
URL: https://github.com/apache/incubator-superset/pull/8576#discussion_r364485768
 
 

 ##########
 File path: superset/connectors/druid/views.py
 ##########
 @@ -341,7 +341,7 @@ def pre_add(self, datasource):
         with db.session.no_autoflush:
             query = db.session.query(models.DruidDatasource).filter(
                 models.DruidDatasource.datasource_name == datasource.datasource_name,
-                models.DruidDatasource.cluster_name == datasource.cluster.id,
+                models.DruidDatasource.cluster_id == datasource.cluster_id,
 
 Review comment:
   Yep 🤷‍♀ 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org