You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ignite.apache.org by "Andrew Mashenkov (JIRA)" <ji...@apache.org> on 2019/04/26 10:54:00 UTC

[jira] [Updated] (IGNITE-11815) Get rid of GridTestUtils.retryAssert method.

     [ https://issues.apache.org/jira/browse/IGNITE-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Mashenkov updated IGNITE-11815:
--------------------------------------
    Description: 
For now we have GridTestUtils.retryAssert() method which runs a closure 'n' times to check if some invariantes become ok, eventually.

This method catch assertions and can print them to log many times even if assertion is acceptable for the moment.
 Also, it is possible to miss an assertion is not related to those ones that closure checks  (e.g. assertion error thrown from ignite internals).

Let's replace retryAssert with GridTestUtils.waitForCondition() usage to make logs clearer and to avoid possible false positive results.

  was:
For now we have GridTestUtils.retryAssert() method which runs a closure 'n' times to check if some invariantes become ok, eventually.

This method catch assertions and can print them to log many times even if assertion is acceptable for the moment.
Also, it is possible to miss an assertion is not related to those ones that closure checks  (e.g. assertion error thrown from ignite internals).

 

Let's replace retryAssert with GridTestUtils.waitForCondition() usage.


> Get rid of GridTestUtils.retryAssert method.
> --------------------------------------------
>
>                 Key: IGNITE-11815
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11815
>             Project: Ignite
>          Issue Type: Test
>            Reporter: Andrew Mashenkov
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>
> For now we have GridTestUtils.retryAssert() method which runs a closure 'n' times to check if some invariantes become ok, eventually.
> This method catch assertions and can print them to log many times even if assertion is acceptable for the moment.
>  Also, it is possible to miss an assertion is not related to those ones that closure checks  (e.g. assertion error thrown from ignite internals).
> Let's replace retryAssert with GridTestUtils.waitForCondition() usage to make logs clearer and to avoid possible false positive results.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)