You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/04/05 19:19:36 UTC

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1105: DISPATCH-836 Standardize #include order

jiridanek commented on a change in pull request #1105:
URL: https://github.com/apache/qpid-dispatch/pull/1105#discussion_r607278251



##########
File path: src/router_core/exchange_bindings.c
##########
@@ -16,14 +16,16 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-#include <qpid/dispatch/ctools.h>
-#include <inttypes.h>
-#include <stdio.h>
-#include "router_core_private.h"
-#include "forwarder.h"
 #include "exchange_bindings.h"

Review comment:
       Here's the only issue the reordering found. `exchange_bindings.h` depended on being included after `"router_core_private.h"`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org