You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by babokim <gi...@git.apache.org> on 2014/07/03 21:11:15 UTC

[GitHub] tajo pull request: TAJO-903: Left outer join should be optimized b...

GitHub user babokim opened a pull request:

    https://github.com/apache/tajo/pull/56

    TAJO-903: Left outer join should be optimized by the broadcast join.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/babokim/tajo TAJO-903

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #56
    
----
commit dc1770aacb83ecaebc0679bd7a4b7b8dbf322f95
Author: 김형준 <ba...@babokim-macbook-pro.local>
Date:   2014-06-11T01:22:29Z

    enhancement broadcast join in the case of left outer join

commit e892f6ddb06a047aa6e7c6e9b30cb1ee0535d612
Author: 김형준 <ba...@babokim-macbook-pro.local>
Date:   2014-06-11T15:48:39Z

    Add more testcase for broadcast join

commit 82297c2af55985a8a79b4e9749df5ea50a3e50e0
Author: 김형준 <ba...@babokim-mbp.server.gruter.com>
Date:   2014-06-30T12:16:37Z

    Add node.setCandidateBroadcast(true) in BroadcastJoinPlanVisitor

commit 840f78a54cddc155cd0c06575903378b17834ae9
Author: 김형준 <ba...@babokim-macbook-pro.local>
Date:   2014-06-30T16:31:15Z

    Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo
    
    Conflicts:
    	tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
    	tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
    	tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java

commit 8a6d0e7acd9c35d029d5ad31ea213e3d30f3441b
Author: 김형준 <ba...@babokim-macbook-pro.local>
Date:   2014-07-03T18:35:14Z

    TAJO-903: Left outer join should be optimized by the broadcast join.

commit 7a93d846a282e5b643e41822fe5deac535b84eb5
Author: 김형준 <ba...@babokim-macbook-pro.local>
Date:   2014-07-03T18:35:36Z

    Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

commit e5e3877e62022aa666c2c43abefe714db22447dd
Author: 김형준 <ba...@babokim-macbook-pro.local>
Date:   2014-07-03T19:08:22Z

    TAJO-903: Left outer join should be optimized by the broadcast join.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-903: Left outer join should be optimized b...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/56#issuecomment-48448719
  
    +1
    
    The patch looks good to me. It includes enough unit tests to verify added features. In addition, I added some of explanation to the source code. I'll commit it shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-903: Left outer join should be optimized b...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/56


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---