[GitHub] [airflow] SamWheating commented on a change in pull request #14280: Add plugins endpoint to the REST API

[GitBox <gi...@apache.org>]

SamWheating commented on a change in pull request #14280:
URL: https://github.com/apache/airflow/pull/14280#discussion_r580672531



##########
File path: airflow/api_connexion/endpoints/plugin_endpoint.py
##########
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.api_connexion import security
+from airflow.api_connexion.exceptions import NotFound
+from airflow.api_connexion.schemas.plugin_schema import PluginCollection, plugin_collection_schema
+from airflow.plugins_manager import get_plugin_info
+from airflow.security import permissions
+
+
+@security.requires_access([(permissions.ACTION_CAN_READ, permissions.RESOURCE_PLUGIN)])
+def get_plugins():
+    """Get plugins endpoint"""
+    plugins_info = get_plugin_info()
+    if plugins_info:
+        return plugin_collection_schema.dump(
+            PluginCollection(plugins=plugins_info, total_entries=len(plugins_info))
+        )
+    raise NotFound(detail="Plugin not found")

Review comment:
       Should this return an empty (but successful) response rather than a 404 if there are no plugins? I believe this is the behaviour of other `list` endpoints. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org