[GitHub] [buildstream] gtristan commented on a diff in pull request #1632: tests: xfail integration tests that fail without buildbox-fuse

[GitBox <gi...@apache.org>]

gtristan commented on code in PR #1632:
URL: https://github.com/apache/buildstream/pull/1632#discussion_r844863301


##########
tests/integration/script.py:
##########
@@ -171,6 +172,7 @@ def test_script_layout(cli, datafiles):
     HAVE_SANDBOX == "buildbox-run" and BUILDBOX_RUN == "buildbox-run-userchroot",
     reason="Root directory not writable with userchroot",
 )
+@pytest.mark.xfail(not HAVE_BUILDBOX_FUSE, reason="Root directory not writable without buildbox-fuse")

Review Comment:
   Normally we use `@pytest.mark.skipif` to conditionally skip tests which we cannot run because of lacking components in the environment.
   
   However here it seems appropriate to conditionally `xfail` the test since this should be considered incorrect behavior of buildstream *regardless* of the absence of `buildbox-fuse`, so it's nice to have the tests complain about this.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org