[GitHub] [maven-resolver] cstamas commented on a diff in pull request #240: [MRESOLVER-319] Parallel Deploy Support

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on code in PR #240:
URL: https://github.com/apache/maven-resolver/pull/240#discussion_r1098533115


##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -284,6 +289,9 @@ public void put( Collection<? extends ArtifactUpload> artifactUploads,
         Collection<? extends ArtifactUpload> safeArtifactUploads = safe( artifactUploads );
         Collection<? extends MetadataUpload> safeMetadataUploads = safe( metadataUploads );
 
+        Executor executor = getExecutor( parallelPut ? safeArtifactUploads.size() + safeMetadataUploads.size() : 1 );

Review Comment:
   It is literally same as this line:
   https://github.com/apache/maven-resolver/pull/240/files#diff-ac0d3c1eeeae1e33fd8674465b3cd81dee6963dd017c290a1ad21173fd7571dcR216
   
   but with option to fall back to 1, in which Direct executor is used (sequential)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org