You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "rt320 (via GitHub)" <gi...@apache.org> on 2023/03/01 11:56:44 UTC

[GitHub] [daffodil-vscode] rt320 commented on pull request #458: Significant modifications made to intellisense results

rt320 commented on PR #458:
URL: https://github.com/apache/daffodil-vscode/pull/458#issuecomment-1450005963

   @Shanedell There is no snippet defined for "dfdl:format ref".  The only reference I could find for it was in the file DFDLGeneralFormat.dfdl.xsd. This file seems to have been added when the code originally in dfdl.ts was split out into multiple files.  The original dfdl.ts file had a snippet defined as "defaultDfdlFormat" which is similar to the beginning of this file, but that snippet was removed.  This file seems to cause one of the issues Mike Beckerle brought up in issue #366.  I was planning to replace the file as part of the solution to issue #366.
   I downloaded the RedHat XML code and tried your example above in the code. This was the result when I pressed the slash key.
   ![image](https://user-images.githubusercontent.com/98881959/222129145-0a3f202f-2675-4a9f-82b6-079e14645a5b.png)
   This was the result when I pressed the '>' key.
   ![image](https://user-images.githubusercontent.com/98881959/222129491-0a1666a6-ef61-4315-8bf7-ad10d2db76b9.png)
   I also tried deleting an end tag in a multi-tag line and having the auto-complete re-insert the closing tag. When I pressed '>' another '>' was added to the end of the line. When I pressed slash I was given the option to add the missing end tag.
   ![image](https://user-images.githubusercontent.com/98881959/222131873-2273b94e-1e02-4cca-9e26-f5807e3e9d32.png)
   When I chose that option, the end tag was added, but the triggering slash was left in place.
   ![image](https://user-images.githubusercontent.com/98881959/222132081-be0479a5-ad92-4d94-a080-62759516f929.png)
   I haven't looked at the RedHat code. Possibly it offers a simpler coding solution, but does not seem to completely handle all situations.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org