You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/02 19:31:37 UTC

[GitHub] [spark] rdblue commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

rdblue commented on issue #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API
URL: https://github.com/apache/spark/pull/25206#issuecomment-517819027
 
 
   @cloud-fan, so you're suggesting Spark should create a new SQL command instead of using `RENAME` because `RENAME` would be confusing?
   
   I think `RENAME` fits this operation. We're just changing the full table name, including namespace, instead of just the short name. In contract, `MOVE` implies a more expensive operation like a copy of data.
   
   Last, `MOVE` would require new parser rules, plans, etc. where using `RENAME` would require only small changes. I see no real benefit to using `MOVE` instead of `RENAME`, and I think that the catalog API would be identical to what is proposed here because Spark doesn't intend to *actually* run a job to copy and *move* a table. In other words, if this is implemented as a catalog operation, it should be rename because the catalog isn't going to run a job to rewrite data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org