You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Richard Emberson (JIRA)" <ji...@apache.org> on 2011/03/02 23:08:37 UTC

[jira] Created: (WICKET-3495) org/apache/wicket/markup/html/form/upload/MultiFileUploadField convertValue question

org/apache/wicket/markup/html/form/upload/MultiFileUploadField convertValue question
------------------------------------------------------------------------------------

                 Key: WICKET-3495
                 URL: https://issues.apache.org/jira/browse/WICKET-3495
             Project: Wicket
          Issue Type: Bug
          Components: wicket-core
    Affects Versions: 1.5-RC2
         Environment: all
            Reporter: Richard Emberson
            Priority: Trivial


This is more of a question concerning code in the convertValue of
org/apache/wicket/markup/html/form/upload/MultiFileUploadField,

Consider:
      for (String filename : filenames)
      {
        List<FileItem> fileItems = request.getFile(filename);
        for (FileItem fileItem : fileItems)
        {
          uploads.add(new FileUpload(fileItem));
        }
      }
Is it always the case that the request.getFile(filename); code always returns a List and
never returns null?


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (WICKET-3495) org/apache/wicket/markup/html/form/upload/MultiFileUploadField convertValue question

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3495.
-------------------------------------

    Resolution: Not A Problem
      Assignee: Martin Grigorov

There is no problem.
The filenames are extracted in getInputAsArray() where "((IMultipartWebRequest)request).getFiles();" is used.

getFiles() has type Map[String, List[FileItem]]
So getInputAsArray() returns the keys and later convertValue() get the value for each key. 
It is not multithreaded, so I see no problems.

> org/apache/wicket/markup/html/form/upload/MultiFileUploadField convertValue question
> ------------------------------------------------------------------------------------
>
>                 Key: WICKET-3495
>                 URL: https://issues.apache.org/jira/browse/WICKET-3495
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.5-RC2
>         Environment: all
>            Reporter: Richard Emberson
>            Assignee: Martin Grigorov
>            Priority: Trivial
>
> This is more of a question concerning code in the convertValue of
> org/apache/wicket/markup/html/form/upload/MultiFileUploadField,
> Consider:
>       for (String filename : filenames)
>       {
>         List<FileItem> fileItems = request.getFile(filename);
>         for (FileItem fileItem : fileItems)
>         {
>           uploads.add(new FileUpload(fileItem));
>         }
>       }
> Is it always the case that the request.getFile(filename); code always returns a List and
> never returns null?

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira