[jira] [Commented] (CASSANDRA-4795) strategy options are not validated

["Sylvain Lebresne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488083#comment-13488083 ] 

Sylvain Lebresne commented on CASSANDRA-4795:
---------------------------------------------

I think that ticket was initially targeting the replication strategy, but there is also a lack of validation for the compaction strategies. In that case, we don't even validate that the value of a know option is correct (or rather, for some of the options we log a warning in the log but just carry on, and AbstractCompactionStrategy.tombstoneThreshold is not validated at all. I do not that in the case of the compaction strategy, we don't currently build the compaction strategy until it's actually needed (i.e. when migration are apply), so we shouldn't "just" throw an exception in the constructor: we need to do as we do for the replication strategy in CreateKeyspaceStatement, i.e. do a trial run of building the strategy to make sure everything's ok. 

I do think we should correctly validate options (and by that I mean doing more than a warning in the log) for both replication and compaction strategy for 1.2. At least we should do it for CQL3 if we've extremely afraid of breaking thrift (but I don't really buy that people would rely on our lack of validation).  
                
> strategy options are not validated
> ----------------------------------
>
>                 Key: CASSANDRA-4795
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4795
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Brandon Williams
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> When creating a keyspace and specifying strategy options, you can pass any k/v pair you like.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira