You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/30 20:59:32 UTC
[GitHub] [arrow-datafusion] retikulum opened a new pull request, #4445: Improve error handling for array downcasting
retikulum opened a new pull request, #4445:
URL: https://github.com/apache/arrow-datafusion/pull/4445
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Discussed in #3152 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
This is the new PR in series to improve error handling for downcasting.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Add `as_xxx_array` functions for following types to downcast:
- `MapArray`
- `NullArray`
- `UnionArray`
- `TimestampNanosecondArray`
- `TimestampMillisecondArray`
- `TimestampMicrosecondArray`
- `TimestampSecondArray`
- `BinaryArray`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4445: Improve error handling for array downcasting
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4445:
URL: https://github.com/apache/arrow-datafusion/pull/4445#issuecomment-1332787175
> Is there any problem about cargo test pyarrow check? Other newly opened PRs are also failed on this test. It seems that problem is in the installation part.
I agree there is some problem (maybe @isidentical has some idea). I haven't had a chance to look at the check recently and I am nearing my end of day here. If no one has figured it out tomorrow I'll look into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] retikulum commented on pull request #4445: Improve error handling for array downcasting
Posted by GitBox <gi...@apache.org>.
retikulum commented on PR #4445:
URL: https://github.com/apache/arrow-datafusion/pull/4445#issuecomment-1332755038
Is there any problem about `cargo test pyarrow` check? Other newly opened PRs are also failed on this test. It seems that problem is in the installation part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4445: Improve error handling for array downcasting
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4445:
URL: https://github.com/apache/arrow-datafusion/pull/4445#issuecomment-1333687329
Benchmark runs are scheduled for baseline = 02534597248c21a5ccf81737c69f171fc85b46bb and contender = 799dd747152f6574638a844986b8ea8470d3f4d6. 799dd747152f6574638a844986b8ea8470d3f4d6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/149bdb108d954e96b5373767c6a2b786...7eaa643174c94d37b7354bfa9400ec86/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a5fac15b172b4c29ac8e10264898d9c0...8b5a405ac0ec47f396aaa443f7f41b6b/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/223dc69484c84c44a2590dcfa0669419...c53152cdb6564cb3ade7766e81af3828/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/66abc266e36a425597e4143c94b767e7...610992a8857a43dda3aaaa55b95ece61/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4445: Improve error handling for array downcasting
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4445:
URL: https://github.com/apache/arrow-datafusion/pull/4445#issuecomment-1333629237
Check got fixed in https://github.com/apache/arrow-datafusion/pull/4450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4445: Improve error handling for array downcasting
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4445:
URL: https://github.com/apache/arrow-datafusion/pull/4445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org