You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/11/21 03:27:58 UTC

[jira] [Commented] (WICKET-6283) Page parameter equality should not depend on named parameters order

    [ https://issues.apache.org/jira/browse/WICKET-6283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15682376#comment-15682376 ] 

ASF subversion and git services commented on WICKET-6283:
---------------------------------------------------------

Commit 6e8808cc199d1804326be3d84f061b5232779513 in wicket's branch refs/heads/wicket-7.x from Pedro Henrique Oliveira dos Santos
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=6e8808c ]

WICKET-6283 ignoring named parameters order when testing PageParameter equality


> Page parameter equality should not depend on named parameters order
> -------------------------------------------------------------------
>
>                 Key: WICKET-6283
>                 URL: https://issues.apache.org/jira/browse/WICKET-6283
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 8.0.0-M2, 7.5.0
>            Reporter: Pedro Santos
>            Assignee: Pedro Santos
>
> Wicket is falling to find the page instance for its request when the named parameters order differs from page's PagePamameter#namedParameter.
> MountMapper, for instance first, decodes query parameters after the ? sign before the named parameters encoded in the URL segments. So:
> the URL: segument/example?cid=0
> decoded by: new MountMapper(MyPage.class, "segment/${my_name}");
> is decoded as: cid=0, my_name=example
> While there is no guarantee, nor documented requirement, that the page should set named parameters in an specific order, Wicket should ignore it and map the request to the page instance regardless of the named parameters order.
> Wicket 6 is not affected since this order test was add during WICKET-4441 to versions 7+



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)