[GitHub] [incubator-linkis] legendtkl commented on a diff in pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin

[GitBox <gi...@apache.org>]

legendtkl commented on code in PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#discussion_r884932711


##########
linkis-engineconn-plugins/engineconn-plugins/hive/pom.xml:
##########
@@ -208,89 +204,6 @@
         <dependency>
             <groupId>org.apache.hadoop</groupId>
             <artifactId>hadoop-client</artifactId>
-            <version>${hadoop.version}</version>
-            <exclusions>

Review Comment:
   why remove the exclusions 



##########
linkis-commons/linkis-common/src/main/scala/org/apache/linkis/common/conf/CommonVars.scala:
##########
@@ -17,14 +17,18 @@
  
 package org.apache.linkis.common.conf
 
+import java.util.Properties
 import scala.collection.JavaConversions._
 
 
 case class CommonVars[T](key: String, defaultValue: T, value: T, description: String = null) {
   val getValue: T = BDPConfiguration.getOption(this).getOrElse(defaultValue)
   def getValue(properties: java.util.Map[String, String]): T = {
-    if(properties == null || !properties.containsKey(key) || properties.get(key) == null) getValue
-    else BDPConfiguration.formatValue(defaultValue, Option(properties.get(key))).get
+    if (!(properties == null || !properties.containsKey(key)) && !(properties.get(key) == null)) {

Review Comment:
   the refactor logic looks more confused than before, why do this refactor?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org