You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/24 09:42:01 UTC
[GitHub] [doris] cambyzju opened a new pull request, #14550: [fix](outfile) duplicate SUCCESS file request
cambyzju opened a new pull request, #14550:
URL: https://github.com/apache/doris/pull/14550
# Proposed changes
Issue Number: close #xxx
## Problem summary
Problem desc:
While we call `SELECT xxx INTO OUTFILE`, if we output data file success, we also write an empty `SUCCESS` file.
But now the problem is:
1. if we write data file failed, we also write out an empty `SUCCESS` file;
2. if we write data file success, we write out the empty `SUCCESS` file twice;
Why the problem:
After https://github.com/apache/doris/pull/5489, we refractor _close_file_writer, but not change the caller.
So we will create `SUCCESS` file once inside `close` function, and the other call while we deconstruct `FileResultWriter`.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
4. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
6. Does it need to update dependencies:
- [ ] Yes
- [ ] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14550: [fix](outfile) duplicate SUCCESS file request
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14550:
URL: https://github.com/apache/doris/pull/14550#issuecomment-1326309147
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.96 seconds
load time: 448 seconds
storage size: 17172276489 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221124111631_clickbench_pr_52159.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg merged pull request #14550: [fix](outfile) duplicate SUCCESS file request
Posted by GitBox <gi...@apache.org>.
yangzhg merged PR #14550:
URL: https://github.com/apache/doris/pull/14550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org