You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Dmitriy V. Ryaboy (Created) (JIRA)" <ji...@apache.org> on 2012/01/02 02:27:30 UTC

[jira] [Created] (PIG-2453) Fetching schema can be very slow for multi-thousand LOADs

Fetching schema can be very slow for multi-thousand LOADs
---------------------------------------------------------

                 Key: PIG-2453
                 URL: https://issues.apache.org/jira/browse/PIG-2453
             Project: Pig
          Issue Type: Bug
            Reporter: Dmitriy V. Ryaboy
            Assignee: Dmitriy V. Ryaboy


When a user tries to load resources with thousands of files using PigStorage, we spend an inordinate amount of time looking for schema files. This is because we check for a schema file per loaded file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2453) Fetching schema can be very slow for multi-thousand LOADs

Posted by "Dmitriy V. Ryaboy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitriy V. Ryaboy updated PIG-2453:
-----------------------------------

      Resolution: Fixed
    Release Note: PigStorage will no longer check for file-specific schemas, and only look for the .pig_schema file in the loaded directory. The file-specific behavior never made it to a release, so this is not a change in expected functionality.
          Status: Resolved  (was: Patch Available)

Committed to 0.10 and trunk.
                
> Fetching schema can be very slow for multi-thousand LOADs
> ---------------------------------------------------------
>
>                 Key: PIG-2453
>                 URL: https://issues.apache.org/jira/browse/PIG-2453
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.11
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>             Fix For: 0.10, 0.11
>
>         Attachments: PIG-2453.patch
>
>
> When a user tries to load resources with thousands of files using PigStorage, we spend an inordinate amount of time looking for schema files. This is because we check for a schema file per loaded file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2453) Fetching schema can be very slow for multi-thousand LOADs

Posted by "Daniel Dai (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178621#comment-13178621 ] 

Daniel Dai commented on PIG-2453:
---------------------------------

Patch looks good. +1 for less fs lookup. Would be even happier if no recursive lookup :)
                
> Fetching schema can be very slow for multi-thousand LOADs
> ---------------------------------------------------------
>
>                 Key: PIG-2453
>                 URL: https://issues.apache.org/jira/browse/PIG-2453
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>         Attachments: PIG-2453.patch
>
>
> When a user tries to load resources with thousands of files using PigStorage, we spend an inordinate amount of time looking for schema files. This is because we check for a schema file per loaded file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2453) Fetching schema can be very slow for multi-thousand LOADs

Posted by "Daniel Dai (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-2453:
----------------------------

    Affects Version/s: 0.11
                       0.10
        Fix Version/s: 0.11
                       0.10
    
> Fetching schema can be very slow for multi-thousand LOADs
> ---------------------------------------------------------
>
>                 Key: PIG-2453
>                 URL: https://issues.apache.org/jira/browse/PIG-2453
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.10, 0.11
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>             Fix For: 0.10, 0.11
>
>         Attachments: PIG-2453.patch
>
>
> When a user tries to load resources with thousands of files using PigStorage, we spend an inordinate amount of time looking for schema files. This is because we check for a schema file per loaded file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2453) Fetching schema can be very slow for multi-thousand LOADs

Posted by "Dmitriy V. Ryaboy (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178258#comment-13178258 ] 

Dmitriy V. Ryaboy commented on PIG-2453:
----------------------------------------

One proposed solution is to only check for .pig_schema files on a per-directory level instead of per-file. We can also probably do fewer NN calls by caching all found schema files and not checking metaFilePath.exists() redundantly.
                
> Fetching schema can be very slow for multi-thousand LOADs
> ---------------------------------------------------------
>
>                 Key: PIG-2453
>                 URL: https://issues.apache.org/jira/browse/PIG-2453
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>
> When a user tries to load resources with thousands of files using PigStorage, we spend an inordinate amount of time looking for schema files. This is because we check for a schema file per loaded file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2453) Fetching schema can be very slow for multi-thousand LOADs

Posted by "Dmitriy V. Ryaboy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitriy V. Ryaboy updated PIG-2453:
-----------------------------------

    Attachment: PIG-2453.patch

Added caching, changed JsonMetadata behavior to ignore file-specific schemas. I don't think this feature was used anywhere except tests anyway (?).
                
> Fetching schema can be very slow for multi-thousand LOADs
> ---------------------------------------------------------
>
>                 Key: PIG-2453
>                 URL: https://issues.apache.org/jira/browse/PIG-2453
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>         Attachments: PIG-2453.patch
>
>
> When a user tries to load resources with thousands of files using PigStorage, we spend an inordinate amount of time looking for schema files. This is because we check for a schema file per loaded file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2453) Fetching schema can be very slow for multi-thousand LOADs

Posted by "Dmitriy V. Ryaboy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitriy V. Ryaboy updated PIG-2453:
-----------------------------------

    Status: Patch Available  (was: Open)
    
> Fetching schema can be very slow for multi-thousand LOADs
> ---------------------------------------------------------
>
>                 Key: PIG-2453
>                 URL: https://issues.apache.org/jira/browse/PIG-2453
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>         Attachments: PIG-2453.patch
>
>
> When a user tries to load resources with thousands of files using PigStorage, we spend an inordinate amount of time looking for schema files. This is because we check for a schema file per loaded file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira