You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Dippatel98 (via GitHub)" <gi...@apache.org> on 2023/04/14 20:03:20 UTC

[GitHub] [beam] Dippatel98 opened a new pull request, #26286: Added dlq and error metrics to pubsublite read schema transform

Dippatel98 opened a new pull request, #26286:
URL: https://github.com/apache/beam/pull/26286

   I have added dlq support in the Pubsub Read schema transform by tagging with an appropriate TupleTag. I have also added a Counter to keep track of the number of failed elements in a bundle.
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Dippatel98 commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "Dippatel98 (via GitHub)" <gi...@apache.org>.
Dippatel98 commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1509173184

   @manavgarg @bvolpato Can you guys please take a look. let me know if anything needs to be changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bvolpato commented on a diff in pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on code in PR #26286:
URL: https://github.com/apache/beam/pull/26286#discussion_r1170695878


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteReadSchemaTransformProvider.java:
##########
@@ -59,12 +68,52 @@
   public static final Set<String> VALID_DATA_FORMATS =
       Sets.newHashSet(VALID_FORMATS_STR.split(","));
 
+  public static final TupleTag<Row> OUTPUT_TAG = new TupleTag<Row>() {};
+  public static final TupleTag<Row> ERROR_TAG = new TupleTag<Row>() {};
+  public static final Schema ERROR_SCHEMA =
+      Schema.builder().addStringField("error").addNullableByteArrayField("row").build();
+
   @Override
   protected @UnknownKeyFor @NonNull @Initialized Class<PubsubLiteReadSchemaTransformConfiguration>
       configurationClass() {
     return PubsubLiteReadSchemaTransformConfiguration.class;
   }
 
+  public static class ErrorFn extends DoFn<SequencedMessage, Row> {
+    private SerializableFunction<byte[], Row> valueMapper;
+    private Counter errorCounter;
+    private Long errorsInBundle = 0L;
+
+    public ErrorFn(String name, SerializableFunction<byte[], Row> valueMapper) {
+      this.errorCounter = Metrics.counter(PubsubLiteReadSchemaTransformProvider.class, name);
+      this.valueMapper = valueMapper;
+    }
+
+    @ProcessElement
+    public void process(@DoFn.Element SequencedMessage seqMessage, MultiOutputReceiver receiver) {
+      try {
+        receiver
+            .get(OUTPUT_TAG)
+            .output(valueMapper.apply(seqMessage.getMessage().getData().toByteArray()));
+      } catch (Exception e) {
+        errorsInBundle += 1;
+        System.out.println("Error while parsing the element" + e.toString());

Review Comment:
   I think we should use LOG and add the exception instead of sysout / .toString(), something like this:
   ```
     LOG.warn("Error while parsing the element", e);
   
   ```
   
   
    (make sure you add the LOG member first)
   
   ```
     private static final Logger LOG = LoggerFactory.getLogger(TokenizationBigTableIO.class);
   
   ```



##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteReadSchemaTransformProvider.java:
##########
@@ -59,12 +68,52 @@
   public static final Set<String> VALID_DATA_FORMATS =
       Sets.newHashSet(VALID_FORMATS_STR.split(","));
 
+  public static final TupleTag<Row> OUTPUT_TAG = new TupleTag<Row>() {};
+  public static final TupleTag<Row> ERROR_TAG = new TupleTag<Row>() {};
+  public static final Schema ERROR_SCHEMA =
+      Schema.builder().addStringField("error").addNullableByteArrayField("row").build();
+
   @Override
   protected @UnknownKeyFor @NonNull @Initialized Class<PubsubLiteReadSchemaTransformConfiguration>
       configurationClass() {
     return PubsubLiteReadSchemaTransformConfiguration.class;
   }
 
+  public static class ErrorFn extends DoFn<SequencedMessage, Row> {
+    private SerializableFunction<byte[], Row> valueMapper;
+    private Counter errorCounter;
+    private Long errorsInBundle = 0L;
+
+    public ErrorFn(String name, SerializableFunction<byte[], Row> valueMapper) {
+      this.errorCounter = Metrics.counter(PubsubLiteReadSchemaTransformProvider.class, name);
+      this.valueMapper = valueMapper;
+    }
+
+    @ProcessElement
+    public void process(@DoFn.Element SequencedMessage seqMessage, MultiOutputReceiver receiver) {
+      try {
+        receiver
+            .get(OUTPUT_TAG)
+            .output(valueMapper.apply(seqMessage.getMessage().getData().toByteArray()));
+      } catch (Exception e) {
+        errorsInBundle += 1;
+        System.out.println("Error while parsing the element" + e.toString());

Review Comment:
   I think we should use LOG and log the exception / stacktraces instead of sysout / .toString(), something like this:
   ```
     LOG.warn("Error while parsing the element", e);
   
   ```
   
   
    (make sure you add the LOG member first)
   
   ```
     private static final Logger LOG = LoggerFactory.getLogger(TokenizationBigTableIO.class);
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bvolpato commented on a diff in pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on code in PR #26286:
URL: https://github.com/apache/beam/pull/26286#discussion_r1170695878


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteReadSchemaTransformProvider.java:
##########
@@ -59,12 +68,52 @@
   public static final Set<String> VALID_DATA_FORMATS =
       Sets.newHashSet(VALID_FORMATS_STR.split(","));
 
+  public static final TupleTag<Row> OUTPUT_TAG = new TupleTag<Row>() {};
+  public static final TupleTag<Row> ERROR_TAG = new TupleTag<Row>() {};
+  public static final Schema ERROR_SCHEMA =
+      Schema.builder().addStringField("error").addNullableByteArrayField("row").build();
+
   @Override
   protected @UnknownKeyFor @NonNull @Initialized Class<PubsubLiteReadSchemaTransformConfiguration>
       configurationClass() {
     return PubsubLiteReadSchemaTransformConfiguration.class;
   }
 
+  public static class ErrorFn extends DoFn<SequencedMessage, Row> {
+    private SerializableFunction<byte[], Row> valueMapper;
+    private Counter errorCounter;
+    private Long errorsInBundle = 0L;
+
+    public ErrorFn(String name, SerializableFunction<byte[], Row> valueMapper) {
+      this.errorCounter = Metrics.counter(PubsubLiteReadSchemaTransformProvider.class, name);
+      this.valueMapper = valueMapper;
+    }
+
+    @ProcessElement
+    public void process(@DoFn.Element SequencedMessage seqMessage, MultiOutputReceiver receiver) {
+      try {
+        receiver
+            .get(OUTPUT_TAG)
+            .output(valueMapper.apply(seqMessage.getMessage().getData().toByteArray()));
+      } catch (Exception e) {
+        errorsInBundle += 1;
+        System.out.println("Error while parsing the element" + e.toString());

Review Comment:
   I think we should use LOG and add the exception instead of .toString(), something like this (make sure you add the LOG member first):
   ```
     private static final Logger LOG = LoggerFactory.getLogger(TokenizationBigTableIO.class);
   ```
   
   ```
           LOG.warn("Error while parsing the element", e);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Dippatel98 commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "Dippatel98 (via GitHub)" <gi...@apache.org>.
Dippatel98 commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1527736539

   I have already run `./gradlew :sdks:java:io:google-cloud-platform:spotlessApply` . It completes successfully but there aren't any changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nickuncaged1201 commented on a diff in pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "nickuncaged1201 (via GitHub)" <gi...@apache.org>.
nickuncaged1201 commented on code in PR #26286:
URL: https://github.com/apache/beam/pull/26286#discussion_r1173143659


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteReadSchemaTransformProvider.java:
##########
@@ -118,12 +166,14 @@ public PCollectionRowTuple expand(PCollectionRowTuple input) {
                                         .build())
                                 .build()))
                     .apply(
-                        MapElements.into(TypeDescriptors.rows())
-                            .via(
-                                seqMess ->
-                                    valueMapper.apply(
-                                        seqMess.getMessage().getData().toByteArray())))
-                    .setRowSchema(beamSchema));
+                        ParDo.of(new ErrorFn("Read-Error-Counter", valueMapper))

Review Comment:
   Can you change the metric name to use format "IO name"-"read/write"-error-counter. Something like PubSubLite-read-error-counter Keeping the same format makes it a bit easier on me later to capture them in our backend.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1509223908

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @robertwb for label java.
   R: @pabloem for label io.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Dippatel98 commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "Dippatel98 (via GitHub)" <gi...@apache.org>.
Dippatel98 commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1529829549

   Spotless is passing now, the code has been cleaned up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Dippatel98 commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "Dippatel98 (via GitHub)" <gi...@apache.org>.
Dippatel98 commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1523865371

   I have incorporated all the changes mentioned in the comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1526350312

   Run Java_Examples_Dataflow_Java11 PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Dippatel98 commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "Dippatel98 (via GitHub)" <gi...@apache.org>.
Dippatel98 commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1513542630

   > Thanks Dip. Is it possible to add a test for this?
   
   I have added a test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1526350886

   Run RAT PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey merged pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey merged PR #26286:
URL: https://github.com/apache/beam/pull/26286


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Dippatel98 commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "Dippatel98 (via GitHub)" <gi...@apache.org>.
Dippatel98 commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1529933378

   @johnjcasey all workflows are passing now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] jrmccluskey commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1513595554

   CC: @johnjcasey 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1526350665

   Run Java_GCP_IO_Direct PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bvolpato commented on a diff in pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on code in PR #26286:
URL: https://github.com/apache/beam/pull/26286#discussion_r1170695878


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteReadSchemaTransformProvider.java:
##########
@@ -59,12 +68,52 @@
   public static final Set<String> VALID_DATA_FORMATS =
       Sets.newHashSet(VALID_FORMATS_STR.split(","));
 
+  public static final TupleTag<Row> OUTPUT_TAG = new TupleTag<Row>() {};
+  public static final TupleTag<Row> ERROR_TAG = new TupleTag<Row>() {};
+  public static final Schema ERROR_SCHEMA =
+      Schema.builder().addStringField("error").addNullableByteArrayField("row").build();
+
   @Override
   protected @UnknownKeyFor @NonNull @Initialized Class<PubsubLiteReadSchemaTransformConfiguration>
       configurationClass() {
     return PubsubLiteReadSchemaTransformConfiguration.class;
   }
 
+  public static class ErrorFn extends DoFn<SequencedMessage, Row> {
+    private SerializableFunction<byte[], Row> valueMapper;
+    private Counter errorCounter;
+    private Long errorsInBundle = 0L;
+
+    public ErrorFn(String name, SerializableFunction<byte[], Row> valueMapper) {
+      this.errorCounter = Metrics.counter(PubsubLiteReadSchemaTransformProvider.class, name);
+      this.valueMapper = valueMapper;
+    }
+
+    @ProcessElement
+    public void process(@DoFn.Element SequencedMessage seqMessage, MultiOutputReceiver receiver) {
+      try {
+        receiver
+            .get(OUTPUT_TAG)
+            .output(valueMapper.apply(seqMessage.getMessage().getData().toByteArray()));
+      } catch (Exception e) {
+        errorsInBundle += 1;
+        System.out.println("Error while parsing the element" + e.toString());

Review Comment:
   I think we should use LOG and add the exception instead of .toString(), something like this:
   ```
     LOG.warn("Error while parsing the element", e);
   
   ```
   
   
    (make sure you add the LOG member first)
   
   ```
     private static final Logger LOG = LoggerFactory.getLogger(TokenizationBigTableIO.class);
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Dippatel98 commented on a diff in pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "Dippatel98 (via GitHub)" <gi...@apache.org>.
Dippatel98 commented on code in PR #26286:
URL: https://github.com/apache/beam/pull/26286#discussion_r1178186879


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteReadSchemaTransformProvider.java:
##########
@@ -59,12 +68,52 @@
   public static final Set<String> VALID_DATA_FORMATS =
       Sets.newHashSet(VALID_FORMATS_STR.split(","));
 
+  public static final TupleTag<Row> OUTPUT_TAG = new TupleTag<Row>() {};
+  public static final TupleTag<Row> ERROR_TAG = new TupleTag<Row>() {};
+  public static final Schema ERROR_SCHEMA =
+      Schema.builder().addStringField("error").addNullableByteArrayField("row").build();
+
   @Override
   protected @UnknownKeyFor @NonNull @Initialized Class<PubsubLiteReadSchemaTransformConfiguration>
       configurationClass() {
     return PubsubLiteReadSchemaTransformConfiguration.class;
   }
 
+  public static class ErrorFn extends DoFn<SequencedMessage, Row> {
+    private SerializableFunction<byte[], Row> valueMapper;
+    private Counter errorCounter;
+    private Long errorsInBundle = 0L;
+
+    public ErrorFn(String name, SerializableFunction<byte[], Row> valueMapper) {
+      this.errorCounter = Metrics.counter(PubsubLiteReadSchemaTransformProvider.class, name);
+      this.valueMapper = valueMapper;
+    }
+
+    @ProcessElement
+    public void process(@DoFn.Element SequencedMessage seqMessage, MultiOutputReceiver receiver) {
+      try {
+        receiver
+            .get(OUTPUT_TAG)
+            .output(valueMapper.apply(seqMessage.getMessage().getData().toByteArray()));
+      } catch (Exception e) {
+        errorsInBundle += 1;
+        System.out.println("Error while parsing the element" + e.toString());

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Dippatel98 commented on a diff in pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "Dippatel98 (via GitHub)" <gi...@apache.org>.
Dippatel98 commented on code in PR #26286:
URL: https://github.com/apache/beam/pull/26286#discussion_r1178187168


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteReadSchemaTransformProvider.java:
##########
@@ -118,12 +166,14 @@ public PCollectionRowTuple expand(PCollectionRowTuple input) {
                                         .build())
                                 .build()))
                     .apply(
-                        MapElements.into(TypeDescriptors.rows())
-                            .via(
-                                seqMess ->
-                                    valueMapper.apply(
-                                        seqMess.getMessage().getData().toByteArray())))
-                    .setRowSchema(beamSchema));
+                        ParDo.of(new ErrorFn("Read-Error-Counter", valueMapper))

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1526351056

   Run Spotless PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1526292655

   LGTM, I'll wait for the actions to run before merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1527677194

   looks like spotless is failing. Can you clean up that check?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Dippatel98 commented on pull request #26286: Added dlq and error metrics to pubsublite read schema transform

Posted by "Dippatel98 (via GitHub)" <gi...@apache.org>.
Dippatel98 commented on PR #26286:
URL: https://github.com/apache/beam/pull/26286#issuecomment-1529834409

   Run Java_GCP_IO_Direct PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org