You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/02 22:32:47 UTC
[GitHub] [pulsar] tomiamao opened a new pull request #11537: [docs] Fix error in brokerClientAuthenticationParameters
tomiamao opened a new pull request #11537:
URL: https://github.com/apache/pulsar/pull/11537
### Motivation
Fixing an error in the documentation; brokerClientAuthenticationParameters should hold the parameters for the broker not the client. Updated to reflect that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #11537: [docs] Fix error in documentation for brokerClientAuthenticationParameters
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #11537:
URL: https://github.com/apache/pulsar/pull/11537#discussion_r682242511
##########
File path: site2/docs/security-tls-authentication.md
##########
@@ -75,7 +75,7 @@ superUserRoles=admin
# Authentication settings of the broker itself. Used when the broker connects to other brokers, either in same or other clusters
brokerClientTlsEnabled=true
brokerClientAuthenticationPlugin=org.apache.pulsar.client.impl.auth.AuthenticationTls
-brokerClientAuthenticationParameters={"tlsCertFile":"/path/my-ca/admin.cert.pem,tlsKeyFile:/path/my-ca/admin.key-pk8.pem"}
+brokerClientAuthenticationParameters={"tlsCertFile":"/path/my-ca/broker.cert.pem,tlsKeyFile:/path/my-ca/broker.key-pk8.pem"}
Review comment:
`brokerClientAuthenticationParameters` is used for the client in the broker, it just needs a superuser role, so it's ok to use admin cert. In this example, we make the admin cert as a superuser, so it should be correct for this setting.
Any issue when you trying to set up with the document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11537: [docs] Fix error in documentation for brokerClientAuthenticationParameters
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11537:
URL: https://github.com/apache/pulsar/pull/11537#issuecomment-892245733
@zymap can you review this PR from the technical perspective? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet closed pull request #11537: [docs] Fix error in documentation for brokerClientAuthenticationParameters
Posted by GitBox <gi...@apache.org>.
Anonymitaet closed pull request #11537:
URL: https://github.com/apache/pulsar/pull/11537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11537: [docs] Fix error in documentation for brokerClientAuthenticationParameters
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11537:
URL: https://github.com/apache/pulsar/pull/11537#issuecomment-892245860
@tomiamao Thanks for your contribution. Does this affect only master or other versioned docs?
If latter, could you please help update all affected versions? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11537: [docs] Fix error in documentation for brokerClientAuthenticationParameters
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #11537:
URL: https://github.com/apache/pulsar/pull/11537#discussion_r737061434
##########
File path: site2/docs/security-tls-authentication.md
##########
@@ -75,7 +75,7 @@ superUserRoles=admin
# Authentication settings of the broker itself. Used when the broker connects to other brokers, either in same or other clusters
brokerClientTlsEnabled=true
brokerClientAuthenticationPlugin=org.apache.pulsar.client.impl.auth.AuthenticationTls
-brokerClientAuthenticationParameters={"tlsCertFile":"/path/my-ca/admin.cert.pem,tlsKeyFile:/path/my-ca/admin.key-pk8.pem"}
+brokerClientAuthenticationParameters={"tlsCertFile":"/path/my-ca/broker.cert.pem,tlsKeyFile:/path/my-ca/broker.key-pk8.pem"}
Review comment:
Hi @tomiamao any progress? If no more feedback, we would like to close this PR later, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11537: [docs] Fix error in documentation for brokerClientAuthenticationParameters
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11537:
URL: https://github.com/apache/pulsar/pull/11537#issuecomment-903372367
Hi @tomiamao, any progress for the code and doc? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #11537: [docs] Fix error in documentation for brokerClientAuthenticationParameters
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11537:
URL: https://github.com/apache/pulsar/pull/11537#issuecomment-927279177
Hi @tomiamao, any progress for the code and doc? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org