You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2016/04/14 12:28:26 UTC

[jira] [Commented] (THRIFT-3763) Fix serialization of i64 larger than 2^53 for browserify

    [ https://issues.apache.org/jira/browse/THRIFT-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240945#comment-15240945 ] 

Hudson commented on THRIFT-3763:
--------------------------------

FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/])
THRIFT-3763 Fix serialization of i64 larger than 2^53 for browserify (nsuke: [https://github.com/apache/thrift/commit/abbc8d0ec19850f7ce1125a7f8b1fc9878aac052])
* lib/nodejs/lib/thrift/int64_util.js


> Fix serialization of i64 larger than 2^53 for browserify
> --------------------------------------------------------
>
>                 Key: THRIFT-3763
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3763
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library
>         Environment: browserify 13.0.0
>            Reporter: Aki Sukegawa
>            Assignee: Aki Sukegawa
>             Fix For: 0.10.0
>
>
> Apparently, storing negative value to Buffer works for node but not for browserify.
> Forcing positive value by (& 0xff) before storing fixed the problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)