You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/02 01:37:02 UTC

[GitHub] [pulsar] hangc0276 opened a new pull request #15000: Expose Netty threads num config to bookkeeper.conf

hangc0276 opened a new pull request #15000:
URL: https://github.com/apache/pulsar/pull/15000


   ### Motivation
   https://github.com/apache/bookkeeper/pull/1612 this PR make the Netty io threads number configurable, but doesn't expose to the `bookkeeper.conf`. This parameter will be usually changed in performance tuning especially deploy this bookie on bare metal which have many cpus. For operation engineer who is unfamiliar with the source code will be hard to do performance tuning.
   
   ### Modification
   Expose this parameter configuration into `bookkeeper.conf` and add more explanation about it. 
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer privilege).
   
   Need to update docs? 
   
   - [x] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [ ] `no-need-doc` 
     
     (Please explain why)
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15000: Expose Netty threads num config to bookkeeper.conf

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15000:
URL: https://github.com/apache/pulsar/pull/15000#issuecomment-1086467426


   @hangc0276:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on a change in pull request #15000: [improve][broker]Expose Netty threads num config to bookkeeper.conf

Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #15000:
URL: https://github.com/apache/pulsar/pull/15000#discussion_r841011236



##########
File path: conf/bookkeeper.conf
##########
@@ -158,6 +158,10 @@ numReadWorkerThreads=8
 # (i.e. recovery reads and adds, and fencing).
 numHighPriorityWorkerThreads=8
 
+# This is the number of threads used by Netty to handle TCP connections.
+# Default is 2 *  Runtime.getRuntime().availableProcessors()
+# serverNumIOThreads=

Review comment:
       We should leave uncommented, so it will be easier to override in K8S with just env variables.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org