[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #877: add groupByExecutor main method doc

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #877: add groupByExecutor main method doc
URL: https://github.com/apache/incubator-iotdb/pull/877#discussion_r387024224
 
 

 ##########
 File path: docs/Documentation-CHN/SystemDesign/5-DataQuery/5-GroupByQuery.md
 ##########
 @@ -111,17 +115,83 @@ private void calcFromBatch(BatchData batchData) throws IOException;
 //使用 Page 或 Chunk 的 Statistics 信息直接计算结果
 private void calcFromStatistics(Statistics statistics) throws QueryProcessException;
 
-//从 reader 中读取数据，并计算
-private List<Pair<AggregateResult, Integer>> calcResult() throws IOException, QueryProcessException;
-
 //清空所有计算结果
 private void resetAggregateResults();
 
 //遍历并计算 page 中的数据
 private boolean readAndCalcFromPage() throws IOException, QueryProcessException;
 
 ```
-`GroupByExecutor` 中因为相同 `path` 的不同聚合函数使用的数据是相同的，所以 `calcFromBatch` 方法就是完成遍历所有聚合函数对 `BatchData` 的计算:
+`GroupByExecutor` 中因为相同 `path` 的不同聚合函数使用的数据是相同的，所以在入口方法 `calcResult` 中负责读取该 `Path` 的所有数据,
+取出来的数据再调用 `calcFromBatch` 方法完成遍历所有聚合函数对 `BatchData` 的计算。
+
+`calcResult` 方法的主要逻辑：
+```
 
 Review comment:
   add a blank line before ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services