You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/06/08 18:56:08 UTC

[GitHub] [accumulo] milleruntime commented on a diff in pull request #2197: Per table crypto + other crypto improvements

milleruntime commented on code in PR #2197:
URL: https://github.com/apache/accumulo/pull/2197#discussion_r892752059


##########
core/src/main/java/org/apache/accumulo/core/spi/crypto/CryptoEnvironment.java:
##########
@@ -28,10 +32,18 @@ public interface CryptoEnvironment {
    * Where in Accumulo the on-disk file encryption takes place.
    */
   enum Scope {
-    WAL, RFILE
+    WAL, TABLE

Review Comment:
   I was looking at these changes again and wondering if we should add another scope: `RECOVERY`. With my changes to the recovery code, we now have the ability to encrypt the R-files during recovery...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org