You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/16 03:14:54 UTC
[GitHub] [apisix-ingress-controller] AlinsRan opened a new pull request, #1530: refactor: unified factory and informer
AlinsRan opened a new pull request, #1530:
URL: https://github.com/apache/apisix-ingress-controller/pull/1530
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1530: refactor: unified factory and informer
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1530:
URL: https://github.com/apache/apisix-ingress-controller/pull/1530#discussion_r1050724477
##########
pkg/providers/types/types.go:
##########
@@ -55,36 +63,58 @@ type ListerInformer struct {
PodLister listerscorev1.PodLister
PodInformer cache.SharedIndexInformer
- ApisixUpstreamLister kube.ApisixUpstreamLister
- ApisixUpstreamInformer cache.SharedIndexInformer
-
ConfigMapLister listerscorev1.ConfigMapLister
ConfigMapInformer cache.SharedIndexInformer
+
+ IngressLister kube.IngressLister
+ IngressInformer cache.SharedIndexInformer
+
+ ApisixUpstreamInformer cache.SharedIndexInformer
+ ApisixRouteInformer cache.SharedIndexInformer
+ ApisixPluginConfigInformer cache.SharedIndexInformer
+ ApisixConsumerInformer cache.SharedIndexInformer
+ ApisixTlsInformer cache.SharedIndexInformer
+ ApisixClusterConfigInformer cache.SharedIndexInformer
+
+ ApisixRouteLister kube.ApisixRouteLister
+ ApisixUpstreamLister kube.ApisixUpstreamLister
+ ApisixPluginConfigLister kube.ApisixPluginConfigLister
+ ApisixConsumerLister kube.ApisixConsumerLister
+ ApisixTlsLister kube.ApisixTlsLister
+ ApisixClusterConfigLister kube.ApisixClusterConfigLister
}
-func (c *ListerInformer) Run(ctx context.Context) {
+func (c *ListerInformer) StartAndWaitSync(ctx context.Context) bool {
Review Comment:
```suggestion
func (c *ListerInformer) StartAndWaitForCacheSync(ctx context.Context) bool {
```
Can we rename it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1530: refactor: unified factory and informer
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1530:
URL: https://github.com/apache/apisix-ingress-controller/pull/1530#issuecomment-1354136639
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1530?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1530](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1530?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8698487) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/d22a6fc820f7699af411b8ecaa971307cfc82dbd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d22a6fc) will **increase** coverage by `0.18%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #1530 +/- ##
==========================================
+ Coverage 41.22% 41.41% +0.18%
==========================================
Files 85 85
Lines 7440 7406 -34
==========================================
Hits 3067 3067
+ Misses 4020 3986 -34
Partials 353 353
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1530?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/providers/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1530/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL2luZ3Jlc3MuZ28=) | `4.09% <0.00%> (+0.10%)` | :arrow_up: |
| [pkg/providers/ingress/provider.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1530/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9pbmdyZXNzL3Byb3ZpZGVyLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/providers/k8s/pod/provider.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1530/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3Byb3ZpZGVycy9rOHMvcG9kL3Byb3ZpZGVyLmdv) | `0.00% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1530: refactor: unified factory and informer
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #1530:
URL: https://github.com/apache/apisix-ingress-controller/pull/1530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1530: refactor: unified factory and informer
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1530:
URL: https://github.com/apache/apisix-ingress-controller/pull/1530#issuecomment-1354851876
I communicated offline with @AlinsRan who has been testing this PR for a long time.
So I think it's safe to merge it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1530: refactor: unified factory and informer
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1530:
URL: https://github.com/apache/apisix-ingress-controller/pull/1530#issuecomment-1354860555
I think we should add some performance testing, and get related metrics and reports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org