You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2018/11/22 00:48:00 UTC
[jira] [Commented] (HIVE-20958) Cleaning of code at Hive-common
using automatic inspection tool.
[ https://issues.apache.org/jira/browse/HIVE-20958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695432#comment-16695432 ]
Hive QA commented on HIVE-20958:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 30s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 31s{color} | {color:blue} common in master has 65 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 29s{color} | {color:red} common: The patch generated 74 new + 1799 unchanged - 181 fixed = 1873 total (was 1980) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 38s{color} | {color:red} common generated 1 new + 56 unchanged - 9 fixed = 57 total (was 65) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 8s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:common |
| | Possible null pointer dereference of codahaleReporter in org.apache.hadoop.hive.common.metrics.metrics2.CodahaleMetrics.initMetricsReporter() on exception path Dereferenced at CodahaleMetrics.java:codahaleReporter in org.apache.hadoop.hive.common.metrics.metrics2.CodahaleMetrics.initMetricsReporter() on exception path Dereferenced at CodahaleMetrics.java:[line 455] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc xml compile findbugs checkstyle |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15036/dev-support/hive-personality.sh |
| git revision | master / ddf3b6c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15036/yetus/diff-checkstyle-common.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15036/yetus/new-findbugs-common.html |
| modules | C: common U: common |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15036/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Cleaning of code at Hive-common using automatic inspection tool.
> ----------------------------------------------------------------
>
> Key: HIVE-20958
> URL: https://issues.apache.org/jira/browse/HIVE-20958
> Project: Hive
> Issue Type: Improvement
> Reporter: slim bouguerra
> Assignee: slim bouguerra
> Priority: Minor
> Attachments: HIVE-20958.patch
>
>
> mostly cleaning imports like .*
> re ordering imports.
> remove the unused ones
> some logic simplification.
> Use lambdas when possible.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)