You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Volker Mische (JIRA)" <ji...@apache.org> on 2010/05/18 13:03:43 UTC

[jira] Created: (COUCHDB-765) load_view contains needles module prefixed function calls

load_view contains needles module prefixed function calls
---------------------------------------------------------

                 Key: COUCHDB-765
                 URL: https://issues.apache.org/jira/browse/COUCHDB-765
             Project: CouchDB
          Issue Type: Improvement
          Components: Database Core
    Affects Versions: 0.11
            Reporter: Volker Mische
            Priority: Trivial
             Fix For: 0.12


It's only a cosmetic change. The load_view/4 in couch_httpd_view.erl contains some calls to functions within the module but prefixes the calls.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COUCHDB-765) load_view contains needles module prefixed function calls

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868632#action_12868632 ] 

Adam Kocoloski commented on COUCHDB-765:
----------------------------------------

Hi Volker, just to clarify, that's not strictly a cosmetic change.  A call to M:F(A) always uses the newest version of the code in the VM, while a call to F(A) uses whatever version is running when the call is made.  The difference is critically important for hot-code loading in the case of a server loop function, e.g. if you do

loop(State) ->
    ...
    loop(State).

you'll never load a new version of the code, but if you do

loop(State) ->
    ...
    ?MODULE:loop(State).

you'll get the new version automatically when the loop recurses.

Of course, it doesn't make any difference in this case, as hot-code loading is not an issue for those functions.  Thanks for the patch.

> load_view contains needles module prefixed function calls
> ---------------------------------------------------------
>
>                 Key: COUCHDB-765
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-765
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Volker Mische
>            Priority: Trivial
>             Fix For: 0.12
>
>         Attachments: load_view.patch
>
>
> It's only a cosmetic change. The load_view/4 in couch_httpd_view.erl contains some calls to functions within the module but prefixes the calls.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (COUCHDB-765) load_view contains needles module prefixed function calls

Posted by "Jan Lehnardt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Lehnardt closed COUCHDB-765.
--------------------------------

    Fix Version/s: 1.0
                       (was: 0.12)
       Resolution: Fixed

> load_view contains needles module prefixed function calls
> ---------------------------------------------------------
>
>                 Key: COUCHDB-765
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-765
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Volker Mische
>            Priority: Trivial
>             Fix For: 1.0
>
>         Attachments: load_view.patch
>
>
> It's only a cosmetic change. The load_view/4 in couch_httpd_view.erl contains some calls to functions within the module but prefixes the calls.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-765) load_view contains needles module prefixed function calls

Posted by "Volker Mische (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Volker Mische updated COUCHDB-765:
----------------------------------

    Attachment: load_view.patch

Patch for the cosmetic change.

> load_view contains needles module prefixed function calls
> ---------------------------------------------------------
>
>                 Key: COUCHDB-765
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-765
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 0.11
>            Reporter: Volker Mische
>            Priority: Trivial
>             Fix For: 0.12
>
>         Attachments: load_view.patch
>
>
> It's only a cosmetic change. The load_view/4 in couch_httpd_view.erl contains some calls to functions within the module but prefixes the calls.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.