You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/06/11 17:15:48 UTC
commons-dbcp git commit: Better lvar name and use line length 120.
Repository: commons-dbcp
Updated Branches:
refs/heads/master b899784ff -> 88bc781f3
Better lvar name and use line length 120.
Project: http://git-wip-us.apache.org/repos/asf/commons-dbcp/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-dbcp/commit/88bc781f
Tree: http://git-wip-us.apache.org/repos/asf/commons-dbcp/tree/88bc781f
Diff: http://git-wip-us.apache.org/repos/asf/commons-dbcp/diff/88bc781f
Branch: refs/heads/master
Commit: 88bc781f326d51424680a3fa6955632a7883b7e8
Parents: b899784
Author: Gary Gregory <ga...@gmail.com>
Authored: Mon Jun 11 11:15:44 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Mon Jun 11 11:15:44 2018 -0600
----------------------------------------------------------------------
.../org/apache/commons/dbcp2/PoolingConnection.java | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-dbcp/blob/88bc781f/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java b/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java
index 1fabf89..0fa4c0b 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java
@@ -308,17 +308,19 @@ public class PoolingConnection extends DelegatingConnection<Connection>
}
/**
- * {@link KeyedPooledObjectFactory} method for passivating
- * {@link PreparedStatement}s or {@link CallableStatement}s.
+ * {@link KeyedPooledObjectFactory} method for passivating {@link PreparedStatement}s or {@link CallableStatement}s.
* Invokes {@link PreparedStatement#clearParameters}.
*
- * @param key ignored
- * @param p a wrapped {@link PreparedStatement}
+ * @param key
+ * ignored
+ * @param pooledObject
+ * a wrapped {@link PreparedStatement}
*/
@Override
- public void passivateObject(final PStmtKey key,
- final PooledObject<DelegatingPreparedStatement> p) throws Exception {
- final DelegatingPreparedStatement dps = p.getObject();
+ public void passivateObject(final PStmtKey key, final PooledObject<DelegatingPreparedStatement> pooledObject)
+ throws Exception {
+ @SuppressWarnings("resource")
+ final DelegatingPreparedStatement dps = pooledObject.getObject();
dps.clearParameters();
dps.passivate();
}