You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/01/03 06:28:13 UTC
[GitHub] [hadoop] ayushtkn commented on a change in pull request #3825: HADOOP-18056. DistCp: Filter duplicates in the source paths.
ayushtkn commented on a change in pull request #3825:
URL: https://github.com/apache/hadoop/pull/3825#discussion_r777308040
##########
File path: hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpOptions.java
##########
@@ -234,7 +236,18 @@ public Path getSourceFileListing() {
public List<Path> getSourcePaths() {
return sourcePaths == null ?
- null : Collections.unmodifiableList(sourcePaths);
+ null :
+ Collections.unmodifiableList(getUniquePaths(sourcePaths));
+ }
+
+ private List<Path> getUniquePaths(List<Path> srcPaths) {
+ Set<Path> uniquePaths = new LinkedHashSet<>();
+ for (Path path : srcPaths) {
+ if (!uniquePaths.add(path)) {
+ LOG.warn("Path: {} added multiple times, Ignoring the redundant entry.", path);
Review comment:
Thanx @tomscut, I have changed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org