You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:20:54 UTC

[GitHub] [beam] mxm commented on a change in pull request #13105: [BEAM-10940] Add sdf initiated checkpoint support to portable Flink.

mxm commented on a change in pull request #13105:
URL: https://github.com/apache/beam/pull/13105#discussion_r516664835



##########
File path: runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -502,6 +690,8 @@ public void close() throws Exception {
     processWatermark1(Watermark.MAX_WATERMARK);
     while (getCurrentOutputWatermark() < Watermark.MAX_WATERMARK.getTimestamp()) {
       invokeFinishBundle();
+      // Sleep for 5s to wait for any timer to be fired.
+      Thread.sleep(5000);

Review comment:
       This is a bug then. All processing timers should be fired on `close()`. It would be great to get rid of the sleep which can have unexpected side effects, e.g. when operators are chained in Flink.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org