You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Robert Kanter (JIRA)" <ji...@apache.org> on 2015/09/11 02:22:45 UTC
[jira] [Commented] (HADOOP-12348) MetricsSystemImpl creates
MetricsSourceAdapter with wrong time unit parameter.
[ https://issues.apache.org/jira/browse/HADOOP-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739906#comment-14739906 ]
Robert Kanter commented on HADOOP-12348:
----------------------------------------
+1 LGTM
> MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter.
> ------------------------------------------------------------------------------
>
> Key: HADOOP-12348
> URL: https://issues.apache.org/jira/browse/HADOOP-12348
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: HADOOP-12348.000.patch, HADOOP-12348.001.patch
>
>
> MetricsSystemImpl creates MetricsSourceAdapter with wrong time unit parameter. MetricsSourceAdapter expects time unit millisecond for jmxCacheTTL but MetricsSystemImpl passes time unit second to MetricsSourceAdapter constructor.
> {code}
> jmxCacheTS = Time.now() + jmxCacheTTL;
> /**
> * Current system time. Do not use this to calculate a duration or interval
> * to sleep, because it will be broken by settimeofday. Instead, use
> * monotonicNow.
> * @return current time in msec.
> */
> public static long now() {
> return System.currentTimeMillis();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)