[GitHub] [maven-archiver] elharo commented on a diff in pull request #42: [MSHARED-1297] Prefer JDK features over plexus-utils, plexus-io

["elharo (via GitHub)" <gi...@apache.org>]

elharo commented on code in PR #42:
URL: https://github.com/apache/maven-archiver/pull/42#discussion_r1296514319


##########
src/main/java/org/apache/maven/archiver/MavenArchiver.java:
##########
@@ -800,6 +800,21 @@ public static Optional<Instant> parseBuildOutputTimestamp(String outputTimestamp
         }
     }
 
+    private static boolean isNumeric(String str) {
+
+        if (str.isEmpty()) {
+            return false;
+        }
+
+        for (char c : str.toCharArray()) {
+            if (!Character.isDigit(c)) {

Review Comment:
   This is likely not what you want. It includes lots of non-ASCII digits like Devanagari digits. Long.parseLong won't work on these.
   
   There might also be an issue with negative numbers. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org