You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/04/19 18:28:33 UTC

[GitHub] [spark] viirya commented on a diff in pull request #40845: [SPARK-43183][SS] Introduce a new callback "onQueryIdle" to StreamingQueryListener

viirya commented on code in PR #40845:
URL: https://github.com/apache/spark/pull/40845#discussion_r1171716059


##########
python/pyspark/sql/streaming/listener.py:
##########
@@ -87,6 +91,14 @@ def onQueryProgress(self, event: "QueryProgressEvent") -> None:
         """
         pass
 
+    @abstractmethod
+    def onQueryIdle(self, event: "QueryIdleEvent") -> None:
+        """
+        Called when the query is idle for a certain time period and waiting for new data to

Review Comment:
   `a certain time period` sounds ambiguous.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org