You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/02/26 20:23:23 UTC

[GitHub] [hbase] bharathv commented on a change in pull request #2970: HBASE-25583: NoNodeException of the peer should call the remove peer workflow

bharathv commented on a change in pull request #2970:
URL: https://github.com/apache/hbase/pull/2970#discussion_r583895056



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummyWithNoTermination.java
##########
@@ -16,11 +16,16 @@
 package org.apache.hadoop.hbase.replication;
 
 public class ReplicationSourceDummyWithNoTermination extends ReplicationSourceDummy {
-
+  boolean firstTime = true;
+  boolean isTerminateInvoked = false;

Review comment:
       `isTerminateInvoked` is unused? nit: may want to make the other one volatile for thread-safety.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org