You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/29 12:39:18 UTC
[GitHub] [spark] beliefer opened a new pull request, #38046: [WIP][SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
beliefer opened a new pull request, #38046:
URL: https://github.com/apache/spark/pull/38046
### What changes were proposed in this pull request?
As we know, `UnsafeRow` stores each field with 8 bytes or Long.
`UnsafeRow` supports read and store `CalendarInterval`.
After my investigation, `getLong`/`putLong` of `Platform` have better performance than call `getInt`/`putInt` of `Platform` twice.
This PR combines two int field `months` and `days` of `CalendarInterval` to a long value. So we could call `getLong` or `putLong` once.
### Why are the changes needed?
Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`.
### Does this PR introduce _any_ user-facing change?
'No'.
Just update the underlying implementation.
### How was this patch tested?
New micro benchmark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #38046:
URL: https://github.com/apache/spark/pull/38046#issuecomment-1272277312
> @beliefer Could you generate results for jdk11 and jdk17, see others benchmark results https://github.com/apache/spark/tree/0db9f11a8aa073af63cf64d3e031fc22b690bf9c/sql/catalyst/benchmarks
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
URL: https://github.com/apache/spark/pull/38046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38046:
URL: https://github.com/apache/spark/pull/38046#discussion_r994202822
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/CalendarIntervalBenchmark.scala:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import org.apache.spark.benchmark.{Benchmark, BenchmarkBase}
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.RowEncoder
+import org.apache.spark.sql.catalyst.expressions.UnsafeProjection
+import org.apache.spark.sql.types.{CalendarIntervalType, DataType, StructType}
+import org.apache.spark.unsafe.types.CalendarInterval
+
+/**
+ * Benchmark for read/write CalendarInterval with two int vs
+ * read/write CalendarInterval with one long.
+ * To run this benchmark:
+ * {{{
+ * 1. without sbt:
+ * bin/spark-submit --class <this class> --jars <spark core test jar> <spark catalyst test jar>
+ * 2. build/sbt "catalyst/Test/runMain <this class>"
+ * 3. generate result:
+ * SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "catalyst/Test/runMain <this class>"
+ * Results will be written to "benchmarks/CalendarIntervalBenchmark-results.txt".
+ * }}}
+ */
+object CalendarIntervalBenchmark extends BenchmarkBase {
+
+ def test(name: String, schema: StructType, numRows: Int, iters: Int): Unit = {
+ assert(schema.length == 1)
+ assert(schema.head.dataType.isInstanceOf[CalendarIntervalType])
+ runBenchmark(name) {
+ val generator = RandomDataGenerator.forType(schema, nullable = false).get
+ val toRow = RowEncoder(schema).createSerializer()
+ val rows = (1 to numRows).map(_ => toRow(generator().asInstanceOf[Row]).copy()).toArray
+
+ val row = InternalRow.apply(new CalendarInterval(0, 0, 0))
+ val unsafeRow = UnsafeProjection.create(Array[DataType](CalendarIntervalType)).apply(row)
+
+ val benchmark =
+ new Benchmark("CalendarInterval For " + name, iters * numRows.toLong, output = output)
+ benchmark.addCase("Call setInterval & getInterval") { _: Int =>
+ for (_ <- 0L until iters) {
+ var i = 0
+ while (i < numRows) {
+ val interval = rows(i).getInterval(0)
+ unsafeRow.setInterval(0, interval)
+ val newInterval = unsafeRow.getInterval(0)
+ assert(interval == newInterval)
Review Comment:
this is benchmark, we don't need to check result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
beliefer commented on code in PR #38046:
URL: https://github.com/apache/spark/pull/38046#discussion_r994355440
##########
sql/catalyst/benchmarks/CalendarIntervalBenchmark-results.txt:
##########
@@ -0,0 +1,11 @@
+================================================================================================
+interval
+================================================================================================
+
+Java HotSpot(TM) 64-Bit Server VM 1.8.0_311-b11 on Mac OS X 10.16
+Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
+CalendarInterval For interval: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38046:
URL: https://github.com/apache/spark/pull/38046#issuecomment-1277755044
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #38046:
URL: https://github.com/apache/spark/pull/38046#issuecomment-1263099306
ping @MaxGekk @gengliangwang @viirya @dongjoon-hyun cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
beliefer commented on code in PR #38046:
URL: https://github.com/apache/spark/pull/38046#discussion_r990576459
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/CalendarIntervalBenchmark.scala:
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import org.apache.spark.benchmark.{Benchmark, BenchmarkBase}
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.RowEncoder
+import org.apache.spark.sql.catalyst.expressions.UnsafeProjection
+import org.apache.spark.sql.catalyst.expressions.codegen.GenerateSafeProjection
+import org.apache.spark.sql.types.{CalendarIntervalType, DataType, StructType}
+import org.apache.spark.unsafe.types.CalendarInterval
+
+/**
+ * Benchmark for read/write CalendarInterval with two int vs
+ * read/write CalendarInterval with one long.
+ * To run this benchmark:
+ * {{{
+ * 1. without sbt:
+ * bin/spark-submit --class <this class> --jars <spark core test jar> <spark catalyst test jar>
+ * 2. build/sbt "catalyst/Test/runMain <this class>"
+ * 3. generate result:
+ * SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "catalyst/Test/runMain <this class>"
+ * Results will be written to "benchmarks/CalendarIntervalBenchmark-results.txt".
+ * }}}
+ */
+object CalendarIntervalBenchmark extends BenchmarkBase {
+
+ def test(name: String, schema: StructType, numRows: Int, iters: Int): Unit = {
+ assert(schema.length == 1)
+ assert(schema.head.dataType.isInstanceOf[CalendarIntervalType])
+ runBenchmark(name) {
+ val generator = RandomDataGenerator.forType(schema, nullable = false).get
+ val toRow = RowEncoder(schema).createSerializer()
+ val attrs = schema.toAttributes
+ val safeProjection = GenerateSafeProjection.generate(attrs, attrs)
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #38046:
URL: https://github.com/apache/spark/pull/38046#issuecomment-1272493947
ping @MaxGekk cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38046:
URL: https://github.com/apache/spark/pull/38046#discussion_r994203162
##########
sql/catalyst/benchmarks/CalendarIntervalBenchmark-results.txt:
##########
@@ -0,0 +1,11 @@
+================================================================================================
+interval
+================================================================================================
+
+Java HotSpot(TM) 64-Bit Server VM 1.8.0_311-b11 on Mac OS X 10.16
+Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
+CalendarInterval For interval: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
Review Comment:
the name is weird, `CalendarInterval` should be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38046:
URL: https://github.com/apache/spark/pull/38046#discussion_r988632686
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/CalendarIntervalBenchmark.scala:
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import org.apache.spark.benchmark.{Benchmark, BenchmarkBase}
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.RowEncoder
+import org.apache.spark.sql.catalyst.expressions.UnsafeProjection
+import org.apache.spark.sql.catalyst.expressions.codegen.GenerateSafeProjection
+import org.apache.spark.sql.types.{CalendarIntervalType, DataType, StructType}
+import org.apache.spark.unsafe.types.CalendarInterval
+
+/**
+ * Benchmark for read/write CalendarInterval with two int vs
+ * read/write CalendarInterval with one long.
+ * To run this benchmark:
+ * {{{
+ * 1. without sbt:
+ * bin/spark-submit --class <this class> --jars <spark core test jar> <spark catalyst test jar>
+ * 2. build/sbt "catalyst/Test/runMain <this class>"
+ * 3. generate result:
+ * SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "catalyst/Test/runMain <this class>"
+ * Results will be written to "benchmarks/CalendarIntervalBenchmark-results.txt".
+ * }}}
+ */
+object CalendarIntervalBenchmark extends BenchmarkBase {
+
+ def test(name: String, schema: StructType, numRows: Int, iters: Int): Unit = {
+ assert(schema.length == 1)
+ assert(schema.head.dataType.isInstanceOf[CalendarIntervalType])
+ runBenchmark(name) {
+ val generator = RandomDataGenerator.forType(schema, nullable = false).get
+ val toRow = RowEncoder(schema).createSerializer()
+ val attrs = schema.toAttributes
+ val safeProjection = GenerateSafeProjection.generate(attrs, attrs)
Review Comment:
can we benchmark `UnsafeRow.setInterval/getInterval` directly, instead of using a projection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #38046:
URL: https://github.com/apache/spark/pull/38046#issuecomment-1278400900
@cloud-fan @MaxGekk Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
beliefer commented on code in PR #38046:
URL: https://github.com/apache/spark/pull/38046#discussion_r994272757
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/CalendarIntervalBenchmark.scala:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import org.apache.spark.benchmark.{Benchmark, BenchmarkBase}
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.RowEncoder
+import org.apache.spark.sql.catalyst.expressions.UnsafeProjection
+import org.apache.spark.sql.types.{CalendarIntervalType, DataType, StructType}
+import org.apache.spark.unsafe.types.CalendarInterval
+
+/**
+ * Benchmark for read/write CalendarInterval with two int vs
+ * read/write CalendarInterval with one long.
+ * To run this benchmark:
+ * {{{
+ * 1. without sbt:
+ * bin/spark-submit --class <this class> --jars <spark core test jar> <spark catalyst test jar>
+ * 2. build/sbt "catalyst/Test/runMain <this class>"
+ * 3. generate result:
+ * SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "catalyst/Test/runMain <this class>"
+ * Results will be written to "benchmarks/CalendarIntervalBenchmark-results.txt".
+ * }}}
+ */
+object CalendarIntervalBenchmark extends BenchmarkBase {
+
+ def test(name: String, schema: StructType, numRows: Int, iters: Int): Unit = {
+ assert(schema.length == 1)
+ assert(schema.head.dataType.isInstanceOf[CalendarIntervalType])
+ runBenchmark(name) {
+ val generator = RandomDataGenerator.forType(schema, nullable = false).get
+ val toRow = RowEncoder(schema).createSerializer()
+ val rows = (1 to numRows).map(_ => toRow(generator().asInstanceOf[Row]).copy()).toArray
+
+ val row = InternalRow.apply(new CalendarInterval(0, 0, 0))
+ val unsafeRow = UnsafeProjection.create(Array[DataType](CalendarIntervalType)).apply(row)
+
+ val benchmark =
+ new Benchmark("CalendarInterval For " + name, iters * numRows.toLong, output = output)
+ benchmark.addCase("Call setInterval & getInterval") { _: Int =>
+ for (_ <- 0L until iters) {
+ var i = 0
+ while (i < numRows) {
+ val interval = rows(i).getInterval(0)
+ unsafeRow.setInterval(0, interval)
+ val newInterval = unsafeRow.getInterval(0)
+ assert(interval == newInterval)
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #38046: [SPARK-40611][SQL] Improve the performance of `setInterval` & `getInterval` for `UnsafeRow`
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #38046:
URL: https://github.com/apache/spark/pull/38046#issuecomment-1277473761
The GA failure is unrelated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org