You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/05/13 16:12:32 UTC
Review Request 34167: Views : Disable redirect for null path info
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34167/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Robert Levas.
Bugs: AMBARI-11106
https://issues.apache.org/jira/browse/AMBARI-11106
Repository: ambari
Description
-------
Supplying null path info for an Ambari view request causes a redirect to the target '/'.
For example ...
http://c6401:8080/views/TEZ/0.7.0.2.3.0.0-1497/t1
causes the server to redirect to ...
http://c6401:8080/views/TEZ/0.7.0.2.3.0.0-1497/t1/
This can be an issue in some cases (i.e. if the request is going through an https proxy).
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java 4207007
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java afad6ce
Diff: https://reviews.apache.org/r/34167/diff/
Testing
-------
Manual tested.
Unit tests updated.
Thanks,
Tom Beerbower
Re: Review Request 34167: Views : Disable redirect for null path info
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34167/#review83622
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On May 13, 2015, 10:12 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34167/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 10:12 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Robert Levas.
>
>
> Bugs: AMBARI-11106
> https://issues.apache.org/jira/browse/AMBARI-11106
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Supplying null path info for an Ambari view request causes a redirect to the target '/'.
>
> For example ...
>
> http://c6401:8080/views/TEZ/0.7.0.2.3.0.0-1497/t1
>
>
> causes the server to redirect to ...
>
>
> http://c6401:8080/views/TEZ/0.7.0.2.3.0.0-1497/t1/
>
>
> This can be an issue in some cases (i.e. if the request is going through an https proxy).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java 4207007
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java afad6ce
>
> Diff: https://reviews.apache.org/r/34167/diff/
>
>
> Testing
> -------
>
> Manual tested.
>
> Unit tests updated.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 34167: Views : Disable redirect for null path info
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34167/#review83620
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On May 13, 2015, 10:12 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34167/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 10:12 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Robert Levas.
>
>
> Bugs: AMBARI-11106
> https://issues.apache.org/jira/browse/AMBARI-11106
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Supplying null path info for an Ambari view request causes a redirect to the target '/'.
>
> For example ...
>
> http://c6401:8080/views/TEZ/0.7.0.2.3.0.0-1497/t1
>
>
> causes the server to redirect to ...
>
>
> http://c6401:8080/views/TEZ/0.7.0.2.3.0.0-1497/t1/
>
>
> This can be an issue in some cases (i.e. if the request is going through an https proxy).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java 4207007
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java afad6ce
>
> Diff: https://reviews.apache.org/r/34167/diff/
>
>
> Testing
> -------
>
> Manual tested.
>
> Unit tests updated.
>
>
> Thanks,
>
> Tom Beerbower
>
>