You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by rsafonseca <gi...@git.apache.org> on 2015/06/14 22:37:28 UTC

[GitHub] cloudstack pull request: Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_F...

GitHub user rsafonseca opened a pull request:

    https://github.com/apache/cloudstack/pull/457

    Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE warnings in B…

    …aseCmd.java
    
    Dateformat objects are not thread safe. Instance field is highly recommended for these

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rsafonseca/cloudstack findbugs74

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #457
    
----
commit 28ff9f713a078b45e49bc2db0d0d1855e698ff76
Author: Rafael da Fonseca <rs...@gmail.com>
Date:   2015-06-14T20:36:08Z

    Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE warnings in BaseCmd.java
    Dateformat objects are not thread safe. Instance field is highly recommended for these

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_F...

Posted by rsafonseca <gi...@git.apache.org>.

Github user rsafonseca commented on the pull request:

    https://github.com/apache/cloudstack/pull/457#issuecomment-112080925
  
    @DaanHoogland it's a fluke, sry :)
    Must have typed "wq1" instead of "wq!" on vi ... fixed and rebased


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_F...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/457


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_F...

Posted by DaanHoogland <gi...@git.apache.org>.

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/457#issuecomment-112071469
  
    there's a new ParamProcessWorker class there (and .java file?) looks like this is a commit fluke instead of a needed addition. please remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---