You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/18 07:27:44 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10184: [Feature-10044][dolphinscheduler-task-http] Implements HTTP parameter passing to the next node

SbloodyS commented on code in PR #10184:
URL: https://github.com/apache/dolphinscheduler/pull/10184#discussion_r948745101


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpParameters.java:
##########
@@ -130,4 +138,69 @@ public int getSocketTimeout() {
     public void setSocketTimeout(int socketTimeout) {
         this.socketTimeout = socketTimeout;
     }
+
+    @Override
+    public void dealOutParam(String result) {
+        if (CollectionUtils.isEmpty(localParams)) {
+            return;
+        }
+        List<Property> outProperty = getOutProperty(localParams);
+        if (CollectionUtils.isEmpty(outProperty)) {
+            return;
+        }
+        if (StringUtils.isEmpty(result)) {
+            varPool.addAll(outProperty);
+            return;
+        }
+        List<Map<String, String>> httpMapByString = getHttpMapByString(result);
+        if (httpMapByString == null || httpMapByString.size() == 0) {
+            return;
+        }
+
+        for (Property info : outProperty) {
+            for (int i = 0; i < httpMapByString.size() ; i++) {
+                Map<String, String> stringStringMap=httpMapByString.get(i);

Review Comment:
   ```suggestion
                   Map<String, String> stringStringMap = httpMapByString.get(i);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org