You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2016/12/13 09:14:42 UTC
[GitHub] flink pull request #2993: [FLINK-5327] Remove IOEXception from StateObject::...
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/2993
[FLINK-5327] Remove IOEXception from StateObject::getStateSize
The signature of ``StateObject::getStateSize`` declares throwing of an ``IOException``. This is an artefact of the state handle refactoring. After more refactoring, there is actually no implementor throwing an exception for this call.
This PR removes the exception from the method signature
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink remove-io-exc-get-size
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2993.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2993
----
commit a2f0726e1696464a0e85740d8ff97997f0dde812
Author: Stefan Richter <s....@data-artisans.com>
Date: 2016-12-12T13:02:25Z
[FLINK-5327] Remove IOEXception from StateObject::getStateSize
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2993: [FLINK-5327] Remove IOEXception from StateObject::...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2993
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2993: [FLINK-5327] Remove IOEXception from StateObject::getStat...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2993
Thanks for the blazing fast review and merge :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2993: [FLINK-5327] Remove IOEXception from StateObject::getStat...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2993
Nice, that is an easy one to review ;-)
+1, will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2993: [FLINK-5327] Remove IOEXception from StateObject::getStat...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2993
CC @StephanEwen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---