[GitHub] [iceberg] openinx commented on a change in pull request #2354: Core: add row key to format v2

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2354:
URL: https://github.com/apache/iceberg/pull/2354#discussion_r602002513



##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -573,8 +610,43 @@ public TableMetadata replaceSortOrder(SortOrder newOrder) {
 
     return new TableMetadata(null, formatVersion, uuid, location,
         lastSequenceNumber, System.currentTimeMillis(), lastColumnId, currentSchemaId, schemas, defaultSpecId, specs,
-        lastAssignedPartitionId, newOrderId, builder.build(), properties, currentSnapshotId, snapshots, snapshotLog,
-        addPreviousFile(file, lastUpdatedMillis));
+        lastAssignedPartitionId, newOrderId, builder.build(), defaultRowKeyId, rowKeys,
+        properties, currentSnapshotId, snapshots, snapshotLog, addPreviousFile(file, lastUpdatedMillis));
+  }
+
+  public TableMetadata updateRowKey(RowKey newKey) {

Review comment:
       We will need to introduce a public iceberg table API to update the RowKey specification, right ?  Maybe we could file a separate issue to address this, we can publish the interface in that issue. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org