You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/09/06 06:22:58 UTC

[GitHub] [incubator-yunikorn-site] chia7712 opened a new pull request #79: [YUNIKORN-835] Reminder readers that web-latest image in docker hub i…

chia7712 opened a new pull request #79:
URL: https://github.com/apache/incubator-yunikorn-site/pull/79


   issue: https://issues.apache.org/jira/browse/YUNIKORN-835


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-site] kingamarton commented on a change in pull request #79: [YUNIKORN-835] Reminder readers that web-latest image in docker hub i…

Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #79:
URL: https://github.com/apache/incubator-yunikorn-site/pull/79#discussion_r702739231



##########
File path: docs/developer_guide/deployment.md
##########
@@ -37,6 +37,7 @@ This command will build an image. The image will be tagged with a default versio
 
 **Note** the default build uses a hardcoded user and tag. You *must* update the `IMAGE_TAG` variable in the `Makefile` to push to an appropriate repository. 
 
+**Note** the yunikorn docker images in docker hub are not updated anymore due to ASF policy. Hence, you should build both scheduler image and web image locally before deploying them.

Review comment:
       I think we should mention that the `latest` images are not updated, just to avoid any confusions. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-site] kingamarton merged pull request #79: [YUNIKORN-835] Reminder readers that web-latest image in docker hub i…

Posted by GitBox <gi...@apache.org>.
kingamarton merged pull request #79:
URL: https://github.com/apache/incubator-yunikorn-site/pull/79


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-site] chia7712 commented on a change in pull request #79: [YUNIKORN-835] Reminder readers that web-latest image in docker hub i…

Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #79:
URL: https://github.com/apache/incubator-yunikorn-site/pull/79#discussion_r702744144



##########
File path: docs/developer_guide/deployment.md
##########
@@ -37,6 +37,7 @@ This command will build an image. The image will be tagged with a default versio
 
 **Note** the default build uses a hardcoded user and tag. You *must* update the `IMAGE_TAG` variable in the `Makefile` to push to an appropriate repository. 
 
+**Note** the yunikorn docker images in docker hub are not updated anymore due to ASF policy. Hence, you should build both scheduler image and web image locally before deploying them.

Review comment:
       make sense. will copy that




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org