[jira] [Updated] (YETUS-723) Overhaul the docker support for 2018

["Allen Wittenauer (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YETUS-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer updated YETUS-723:
-----------------------------------
    Release Note: 
<!-- markdown -->
This change represents a fairly large overhaul of precommit's Docker support in order to fix many outstanding bugs and feature requests.  As a result, there are several incompatible changes from previous versions.  Please see the precommit Docker documentation for additional information.

End Users: New Features
=======================

* Support for pulling a pre-built tag instead of building the base image, platforms, non-standard dockerd socket, and Docker-in-Docker.
* `COPY` and `ADD` support when building (requires Docker API version 18+).
* All Yetus built images are now labeled with `org.apache.yetus` to make them easier to find via docker inspect.
* Docker information in the vote table now properly includes a link to the Dockerfile if URLs, artifacting, etc, are turned on.
* Image cleanup should be more reliable.

End Users: Incompatible Changes
===============================

* The minimum Docker version is now version 17.xx.  It was previously 6.xx.
* `--dockeronfail` is no longer supported.
* `ANT_ARGS`, `ANT_OPTS`, and `MAVEN_OPTS` are now honored.  Before they were always overwritten.
* `yetus/tp-(number)` images are now removed after normal completion.
* Because of the addition of Docker-in-Docker support, Docker mode no longer defaults to privileged mode and the flag has been renamed to be consistent with the other flags.  To enable privileged mode, the `--docker-privd` flag must be set to true.

Developers: New Features
========================

* `--docker-bash-debug` will run test-patch.sh with `bash -x` inside the container for extensive debugging.
* yetuslib now sports a new `yetus_file_to_array` function.

Developers: Incompatible Changes
================================

* test-patch.sh's `relative_dir` has been promoted to yetuslib as `yetus_relative_dir` 
* The internal `ANT_ARGS` has been replaced with `YETUS_ANT_ARGS`
* Many changes to how parameters are passed between pre-Docker and post-Docker.

  was:
<!-- markdown -->
This change represents a fairly large overhaul of precommit's Docker support in order to fix many outstanding bugs and feature requests.  As a result, there are several incompatible changes from previous versions.  Please see the precommit Docker documentation for additional information.

End Users: New Features
=======================

* Support for pulling a pre-built tag instead of building the base image, platforms, non-standard dockerd socket, and Docker-in-Docker.
* `COPY` and `ADD` support when building (requires Docker API version 18+).
* All Yetus built images are now labeled with `org.apache.yetus` to make them easier to find via docker inspect.
* Docker information in the vote table now properly includes a link to the Dockerfile if URLs, artifacting, etc, are turned on.
* Image cleanup should be more reliable.

End Users: Incompatible Changes
===============================

* The minimum Docker version is now version 17.xx.  It was prevously 6.xx.
* `--dockeronfail` is no longer supported.
* `ANT_ARGS`, `ANT_OPTS`, and `MAVEN_OPTS` are now honored.  Before they were always overwritten.
* `yetus/tp-(number)` images are now removed after normal completion.
* Because of the addition of Docker-in-Docker support, Docker mode no longer defaults to privileged mode and the flag has been renamed to be consistent with the other flags.  To enable privileged mode, the `--docker-privd` flag must be set to true.

Developers: New Features
========================

* `--docker-bash-debug` will run test-patch.sh with `bash -x` inside the container for extensive debugging.
* yetuslib now sports a new `yetus_file_to_array` function.

Developers: Incompatible Changes
================================

* test-patch.sh's `relative_dir` has been promoted to yetuslib as `yetus_relative_dir` 
* The internal `ANT_ARGS` has been replaced with `YETUS_ANT_ARGS`
* Many changes to how parameters are passed between pre-Docker and post-Docker.


> Overhaul the docker support for 2018
> ------------------------------------
>
>                 Key: YETUS-723
>                 URL: https://issues.apache.org/jira/browse/YETUS-723
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Precommit
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Major
>             Fix For: 0.9.0
>
>         Attachments: YETUS-723.003.patch, YETUS-723.02.patch, YETUS-723.aw-repo-00.patch, YETUS-723.aw-repo-01.patch
>
>
> Many core parts of the Docker support haven't been touched in 3 years.  Since that time, we have learned many things about how people use Docker with test-patch and Docker itself has added many new features.  It's time to overhaul the basic plug-in to take advantage of everything we've learned.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)